linux-kernel - RE: [PATCH 1/1] linux/container_of.h: Warn about loss of constness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9df89d15b77446fae5c64f96e2cb6ad@AcuMS.aculab.com>
Date:   Mon, 24 Oct 2022 10:05:06 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Greg Kroah-Hartman' <gregkh@...uxfoundation.org>
CC:     'Andy Shevchenko' <andriy.shevchenko@...ux.intel.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Subject: RE: [PATCH 1/1] linux/container_of.h: Warn about loss of constness

From: Greg Kroah-Hartman
> Sent: 24 October 2022 11:02
> 
> On Mon, Oct 24, 2022 at 09:46:40AM +0000, David Laight wrote:
> > From: 'Andy Shevchenko'
> > > Sent: 24 October 2022 10:37
> > > ...
> > >
> > > > > > > Wait, no one uses this macro, so why not just remove it entirely?
...
> > It might be interesting to check how many of the function
> > can actually have a NULL pointer?
> > Especially in staging code might be being 'defensive'.
> 
> This is a pointless discussion, this macro will now be deleted, sorry.

I think we actually agree :-)

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)