linux-kernel - Re: [PATCH v2 0/4] staging: r8188eu: cleaning up unused variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+uqrQDuJQ3yBY8_re===u0f97pyr_hn_VNu6LqLJAZnDeqhVQ@mail.gmail.com>
Date:   Mon, 24 Oct 2022 20:23:08 +0900
From:   Kang Minchul <tegongkang@...il.com>
To:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Pavel Skripkin <paskripkin@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/4] staging: r8188eu: cleaning up unused variables

2022년 10월 24일 (월) 오후 5:49, Kang Minchul <tegongkang@...il.com>님이 작성:
>
> This patch series cleans up unused variables in r8188eu
> causing coccicheck warnings.
>
> Difference between v1 and this patch is that this patch series
> include making function amsdu_to_msdu in /r8188eu/core/rtw_recv.c
> into void function.
>
> Kang Minchul (4):
>   staging: r8188eu: remove unnecessary variable in ioctl_linux
>   staging: r8188eu: make amsdu_to_msdu void function
>   staging: r8188eu: remove unnecessary variable in rtl8188eu_xmit
>   staging: r8188eu: remove unnecessary variable in rtw_ap
>
>  drivers/staging/r8188eu/core/rtw_ap.c        | 5 ++---
>  drivers/staging/r8188eu/core/rtw_recv.c      | 5 +----
>  drivers/staging/r8188eu/hal/rtl8188eu_xmit.c | 3 +--
>  drivers/staging/r8188eu/os_dep/ioctl_linux.c | 4 +---
>  4 files changed, 5 insertions(+), 12 deletions(-)
>
> --
> 2.34.1
>
Oh, I guess patch 4/4 can be fixed as well.
I think the function rtw_sta_flush can be void as well.

I'll resend the patch later.

regards,
Kang Minchul