lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y1crluIArwEksyIp@amd.com>
Date:   Tue, 25 Oct 2022 08:19:34 +0800
From:   Huang Rui <ray.huang@....com>
To:     "Meng, Li (Jassmine)" <Li.Meng@....com>
Cc:     Shuah Khan <skhan@...uxfoundation.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        "Fontenot, Nathan" <Nathan.Fontenot@....com>,
        "Sharma, Deepak" <Deepak.Sharma@....com>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Limonciello, Mario" <Mario.Limonciello@....com>,
        "Huang, Shimmer" <Shimmer.Huang@....com>,
        "Yuan, Perry" <Perry.Yuan@....com>,
        "Du, Xiaojian" <Xiaojian.Du@....com>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Borislav Petkov <bp@...en8.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V4 0/4] Add tbench/gitsource new test cases for
 amd-pstate-ut

On Mon, Oct 24, 2022 at 09:33:52AM +0800, Meng, Li (Jassmine) wrote:
> Hi all:
> 
> First, we modify amd-pstate-ut.sh to basic.sh as a basic test, mainly for
> AMD P-State kernel drivers. The purpose of this modification is to
> facilitate the subsequent addition of gitsource, tbench and other tests.
> You can test specific functions by specifying test cases.
> Default test all cases, include basic, tbench and gitsource etc.
> 
> Secondly, add tbench.sh trigger the tbench testing and monitor the cpu
> 
> Third, add gitsource.sh trigger the gitsource testing and monitor the cpu
> information.
> 
> Finally, modify rst document to introduce test steps and results etc.
> 

Series look good for me right now, thanks!
Next time, please send them to linux-kselftest@...r.kernel.org as well.

Acked-by: Huang Rui <ray.huang@....com>

Shuah, could you please take a look at these series?

Thanks,
Ray

> See patch series in below git repo:
> V1:https://lore.kernel.org/lkml/20220706073622.672135-1-li.meng@amd.com/
> V2:https://lore.kernel.org/lkml/20220804054414.1510764-1-li.meng@amd.com/
> V3:https://lore.kernel.org/lkml/20220914061105.1982477-1-li.meng@amd.com/
> 
> Changes from V1->V2:
> - selftests: amd-pstate: basic
> - - delete main.sh and merge funtions into run.sh
> - selftests: amd-pstate: tbench
> - - modify ppw to performance per watt for tbench.
> - - add comments for performance per watt for tbench.
> - - add comparative test on acpi-cpufreq for tbench.
> - - calculate drop between amd-pstate and acpi-cpufreq etc.
> - - plot images about perfrmance,energy and ppw for tbench.
> - selftests: amd-pstate: gitsource
> - - modify ppw to performance per watt for gitsource.
> - - add comments for performance per watt for gitsource.
> - - add comparative test on acpi-cpufreq for gitsource.
> - - calculate drop between amd-pstate and acpi-cpufreq etc.
> - - plot images about perfrmance,energy and ppw for gitsource.
> - Documentation: amd-pstate:
> - - modify rst doc, introduce comparative test etc.
> 
> Changes from V2->V3:
> - selftests: amd-pstate:
> - - reduce print logs for governor.
> - - add a check to see if tbench and the perf tools are already installed.
> - - install tbench package from apt or yum.
> - - correct spelling errors from comprison to comparison.
> 
> Changes from V2->V3:
> - selftests: amd-pstate:
> - - modify cover letter and commit logs.
> - Documentation: amd-pstate:
> - - modify some format questions.
> 
> Thanks, 
> Jasmine 
> 
> Meng Li (4):
>   selftests: amd-pstate: Modify amd-pstate-ut.sh to basic.sh.
>   selftests: amd-pstate: Trigger tbench benchmark and test cpus
>   selftests: amd-pstate: Trigger gitsource benchmark and test cpus
>   Documentation: amd-pstate: Add tbench and gitsource test introduction
> 
>  Documentation/admin-guide/pm/amd-pstate.rst   | 194 ++++++++-
>  tools/testing/selftests/amd-pstate/Makefile   |  11 +-
>  .../selftests/amd-pstate/amd-pstate-ut.sh     |  56 ---
>  tools/testing/selftests/amd-pstate/basic.sh   |  38 ++
>  .../testing/selftests/amd-pstate/gitsource.sh | 345 ++++++++++++++++
>  tools/testing/selftests/amd-pstate/run.sh     | 387 ++++++++++++++++++
>  tools/testing/selftests/amd-pstate/tbench.sh  | 334 +++++++++++++++
>  7 files changed, 1288 insertions(+), 77 deletions(-)
>  delete mode 100755 tools/testing/selftests/amd-pstate/amd-pstate-ut.sh
>  create mode 100755 tools/testing/selftests/amd-pstate/basic.sh
>  create mode 100755 tools/testing/selftests/amd-pstate/gitsource.sh
>  create mode 100755 tools/testing/selftests/amd-pstate/run.sh
>  create mode 100755 tools/testing/selftests/amd-pstate/tbench.sh
> 
> -- 
> 2.34.1
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ