linux-kernel - Re: [PATCH 1/1] dt-bindings: net: snps,dwmac: Document queue config subnodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Oct 2022 16:17:32 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Jose Abreu <joabreu@...opsys.com>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...labora.com
Subject: Re: [PATCH 1/1] dt-bindings: net: snps,dwmac: Document queue config
 subnodes

Hi,

On Mon, Oct 24, 2022 at 07:28:29PM -0400, Krzysztof Kozlowski wrote:
> Old binding did not document "tx-queues-config". Old binding had
> "snps,mtl-tx-config" which was a phandle, so this is an ABI break of
> bindings.
>
> You are changing the binding - adding new properties.

The new binding still has the phandle. The only thing I changed is
explicitly allowing the referenced node to be a subnode of the dwmac
node. This is 100% compatible, since the binding does not specify
where the referenced node should be. Only the example suggested it
could be next to the ethernet node. But changing any properties in
the config node means a ABI break requiring code changes.

Note, that right now 4/7 devicetrees with snps,mtl-tx-config already
follow the scheme I documented. The other 3 have the queue config
below the root node like the current example:

has the queues config in /:
 * arch/arm/boot/dts/artpec6.dtsi
 * arch/arm64/boot/dts/mediatek/mt2712e.dtsi
 * arch/arm64/boot/dts/qcom/sa8155p-adp.dts

has the queues config in the ethernet node:
 * arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
 * arch/arm64/boot/dts/freescale/imx8mp-evk.dts
 * arch/arm64/boot/dts/rockchip/rk3568.dtsi
 * arch/arm64/boot/dts/rockchip/rk356x.dtsi

After my change both are considered valid. Anyways I'm doing this
for rk3588 and planned to follow the subnode style. But if I have
to fully fix this mess I will just put the queue config to the
root node instead and let somebody else figure this out.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)