linux-kernel - Re: [PATCH] KVM: arm64: Use correct accessor to parse stage-1 PTEs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <166671184422.541929.12583367055859537857.b4-ty@kernel.org>
Date:   Tue, 25 Oct 2022 16:30:50 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Alexandru Elisei <alexandru.elisei@....com>,
        Oliver Upton <oliver.upton@...ux.dev>,
        Quentin Perret <qperret@...gle.com>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Will Deacon <will@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        James Morse <james.morse@....com>
Cc:     kvmarm@...ts.linux.dev, linux-kernel@...r.kernel.org,
        kvmarm@...ts.cs.columbia.edu, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] KVM: arm64: Use correct accessor to parse stage-1 PTEs

On Tue, 25 Oct 2022 14:51:56 +0000, Quentin Perret wrote:
> hyp_get_page_state() is used with pKVM to retrieve metadata about a page
> by parsing a hypervisor stage-1 PTE. However, it incorrectly uses a
> helper which parses *stage-2* mappings. Ouch.
> 
> Luckily, pkvm_getstate() only looks at the software bits, which happen
> to be in the same place for stage-1 and stage-2 PTEs, and this all ends
> up working correctly by accident. But clearly, we should do better.
> 
> [...]

Applied to fixes, thanks!

[1/1] KVM: arm64: Use correct accessor to parse stage-1 PTEs
      commit: 6853a71726b6f5930b4450889faf02e8f1cfe35c

Cheers,

	M.
-- 
Without deviation from the norm, progress is not possible.