linux-kernel - Re: [PATCH 0/2] thermal: Validate new state in cur_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0g9v6nsw1UftD7zGVYXKKTUN1y_sLgFG7Z+h9hVXoxU8w@mail.gmail.com>
Date:   Tue, 25 Oct 2022 18:59:58 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Amit Kucheria <amitk@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Zhang Rui <rui.zhang@...el.com>, linux-pm@...r.kernel.org,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] thermal: Validate new state in cur_state_store()

On Mon, Oct 17, 2022 at 12:03 PM Viresh Kumar <viresh.kumar@...aro.org> wrote:
>
> In cur_state_store(), the new state of the cooling device is received
> from user-space and is not validated by the thermal core but the same is
> left for the individual drivers to take care of. Apart from duplicating
> the code it leaves possibility for introducing bugs where a driver may
> not do it right.
>
> Lets make the thermal core check the new state itself and store the max
> value in the cooling device structure.
>
> Once this is merged, I will update the thermal drivers to stop checking
> for the same.
>
> Based of v6.1-rc1.
>
> Viresh Kumar (2):
>   thermal: Validate new state in cur_state_store()
>   thermal: sysfs: Reuse cdev->max_state
>
>  drivers/thermal/gov_fair_share.c |  6 +-----
>  drivers/thermal/thermal_core.c   | 15 ++++++-------
>  drivers/thermal/thermal_sysfs.c  | 37 +++++++++++++-------------------
>  include/linux/thermal.h          |  1 +
>  4 files changed, 24 insertions(+), 35 deletions(-)
>
> --

Both patches in the series applied as 6.2 material, thanks!