linux-kernel - Re: [PATCH v2] staging: rtl8192e: remove bogus ssid character sign test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHmME9oOtdQkC_UVwiEJOcY7chz5RMuys20B+fZ9gOEz7z5zhg@mail.gmail.com>
Date:   Tue, 25 Oct 2022 19:43:29 +0200
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Philipp Hortmann <philipp.g.hortmann@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev,
        dan.carpenter@...cle.com, gregkh@...uxfoundation.org,
        kvalo@...nel.org, linux-wireless@...r.kernel.org
Subject: Re: [PATCH v2] staging: rtl8192e: remove bogus ssid character sign test

On Tue, Oct 25, 2022 at 7:35 PM Philipp Hortmann
<philipp.g.hortmann@...il.com> wrote:
>
> On 10/25/22 14:21, Jason A. Donenfeld wrote:
> > This error triggers on some architectures with unsigned `char` types:
> >
> > drivers/staging/rtl8192e/rtllib_softmac_wx.c:459 rtllib_wx_set_essid() warn: impossible condition '(extra[i] < 0) => (0-255 < 0)'
> >
> > But actually, the entire test is bogus, as ssids don't have any sign
> > validity rules like that. So just remove this check look all together.
> >
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Cc: linux-staging@...ts.linux.dev
> > Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>
> > ---
> > Changes v1->v2:
> > - Remove ssid sign test entirely rather than casting to `s8 *`.
> >
> >   drivers/staging/rtl8192e/rtllib_softmac_wx.c | 9 +--------
> >   1 file changed, 1 insertion(+), 8 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> > index f9589c5b62ba..1e5ad3b476ef 100644
> > --- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> > +++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> > @@ -439,7 +439,7 @@ int rtllib_wx_set_essid(struct rtllib_device *ieee,
> >                       union iwreq_data *wrqu, char *extra)
> >   {
> >
> > -     int ret = 0, len, i;
> > +     int ret = 0, len;
> >       short proto_started;
> >       unsigned long flags;
> >
> > @@ -455,13 +455,6 @@ int rtllib_wx_set_essid(struct rtllib_device *ieee,
> >               goto out;
> >       }
> >
> > -     for (i = 0; i < len; i++) {
> > -             if (extra[i] < 0) {
> > -                     ret = -1;
> > -                     goto out;
> > -             }
> > -     }
> > -
> >       if (proto_started)
> >               rtllib_stop_protocol(ieee, true);
>
> This patch cannot be applied on:
> [PATCH] staging: rtl8192e: use explicitly signed char

They're mutually exclusive, which is why this one here was marked as a
v2 and sent in reply to that one. Greg picked up the v2 and all is
well.

Jason