linux-kernel - Re: [PATCH] staging: rtl8192e: rtllib_crypt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <262e9819-88c4-abc9-dcce-ee020b847c6a@gmail.com>
Date:   Tue, 25 Oct 2022 20:03:07 +0200
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Aaron Lawrence <t4rmin@...omail.com>, gregkh@...uxfoundation.org
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: rtllib_crypt_wep: multiple blank lines
 removal

On 10/25/22 12:44, Aaron Lawrence wrote:
> Removal of multiple unnecessary blank lines in accordance with the
> Linux kernel coding-style regulations. Said issues ware detected on
> this file by the checkpatch script.
> 
> Signed-off-by: Aaron Lawrence <t4rmin@...omail.com>
> ---
>   drivers/staging/rtl8192e/rtllib_crypt_wep.c | 8 --------
>   1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_crypt_wep.c b/drivers/staging/rtl8192e/rtllib_crypt_wep.c
> index 7790271a6a40..062285e4d939 100644
> --- a/drivers/staging/rtl8192e/rtllib_crypt_wep.c
> +++ b/drivers/staging/rtl8192e/rtllib_crypt_wep.c
> @@ -27,7 +27,6 @@ struct prism2_wep_data {
>   	struct arc4_ctx tx_ctx_arc4;
>   };
>   
> -
>   static void *prism2_wep_init(int keyidx)
>   {
>   	struct prism2_wep_data *priv;
> @@ -46,7 +45,6 @@ static void *prism2_wep_init(int keyidx)
>   	return priv;
>   }
>   
> -
>   static void prism2_wep_deinit(void *priv)
>   {
>   	kfree_sensitive(priv);
> @@ -120,7 +118,6 @@ static int prism2_wep_encrypt(struct sk_buff *skb, int hdr_len, void *priv)
>   	return 0;
>   }
>   
> -
>   /* Perform WEP decryption on given struct buffer. Buffer includes whole WEP
>    * part of the frame: IV (4 bytes), encrypted payload (including SNAP header),
>    * ICV (4 bytes). len includes both IV and ICV.
> @@ -180,7 +177,6 @@ static int prism2_wep_decrypt(struct sk_buff *skb, int hdr_len, void *priv)
>   	return 0;
>   }
>   
> -
>   static int prism2_wep_set_key(void *key, int len, u8 *seq, void *priv)
>   {
>   	struct prism2_wep_data *wep = priv;
> @@ -194,7 +190,6 @@ static int prism2_wep_set_key(void *key, int len, u8 *seq, void *priv)
>   	return 0;
>   }
>   
> -
>   static int prism2_wep_get_key(void *key, int len, u8 *seq, void *priv)
>   {
>   	struct prism2_wep_data *wep = priv;
> @@ -207,7 +202,6 @@ static int prism2_wep_get_key(void *key, int len, u8 *seq, void *priv)
>   	return wep->key_len;
>   }
>   
> -
>   static void prism2_wep_print_stats(struct seq_file *m, void *priv)
>   {
>   	struct prism2_wep_data *wep = priv;
> @@ -231,13 +225,11 @@ static struct lib80211_crypto_ops rtllib_crypt_wep = {
>   	.owner			= THIS_MODULE,
>   };
>   
> -
>   static int __init rtllib_crypto_wep_init(void)
>   {
>   	return lib80211_register_crypto_ops(&rtllib_crypt_wep);
>   }
>   
> -
>   static void __exit rtllib_crypto_wep_exit(void)
>   {
>   	lib80211_unregister_crypto_ops(&rtllib_crypt_wep);

Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com>