linux-kernel - Re: [PATCH v2 0/4] staging: rtl8712: clean up dynamic memory management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e72ff575-4ed3-77ca-fa76-27a0e084b1d7@gmail.com>
Date:   Tue, 25 Oct 2022 20:37:39 +0200
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Nam Cao <namcaov@...il.com>,
        Larry Finger <Larry.Finger@...inger.net>,
        Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/4] staging: rtl8712: clean up dynamic memory
 management

On 10/25/22 11:12, Nam Cao wrote:
> This driver is fine if memory allocation never fails. However it does not
> handle allocation failure well. This can either lead to memory leak, or
> unallocated buffers being used.
> 
> v2: Add a missing if statement, as noticed by Dan Carpenter
> 
> Nam Cao (4):
>    Revert "staging: r8712u: Tracking kmemleak false positives."
>    staging: rtl8712: check for alloc fail in _r8712_init_recv_priv()
>    staging: rtl8712: check for return value of _r8712_init_xmit_priv()
>    staging: rtl8712: fix potential memory leak
> 
>   drivers/staging/rtl8712/os_intfs.c     | 27 +++++++++++++++++++++-----
>   drivers/staging/rtl8712/recv_osdep.h   |  8 ++++----
>   drivers/staging/rtl8712/rtl8712_recv.c |  7 ++++---
>   drivers/staging/rtl8712/rtl871x_recv.c | 16 ++++++++-------
>   4 files changed, 39 insertions(+), 19 deletions(-)
> 

Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com>