linux-kernel - Re: [PATCH] arm64: tegra: Add ECAM aperture info for all the PCIe controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ae12e902-a130-0978-37fd-727564325bc0@nvidia.com>
Date:   Tue, 25 Oct 2022 19:45:24 +0100
From:   Jon Hunter <jonathanh@...dia.com>
To:     Vidya Sagar <vidyas@...dia.com>, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, thierry.reding@...il.com,
        mperttunen@...dia.com
Cc:     devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org, kthota@...dia.com,
        mmaddireddy@...dia.com, sagar.tv@...il.com
Subject: Re: [PATCH] arm64: tegra: Add ECAM aperture info for all the PCIe
 controllers


On 25/10/2022 19:27, Vidya Sagar wrote:
> Add the ECAM aperture information for all the PCIe controllers of
> Tegra234.
> 
> Signed-off-by: Vidya Sagar <vidyas@...dia.com>
> ---
>   arch/arm64/boot/dts/nvidia/tegra234.dtsi | 55 ++++++++++++++----------
>   1 file changed, 33 insertions(+), 22 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> index 85b0dea33117..f5d20f7253b0 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> @@ -2044,8 +2044,9 @@
>   		reg = <0x00 0x140a0000 0x0 0x00020000>, /* appl registers (128K)      */
>   		      <0x00 0x2a000000 0x0 0x00040000>, /* configuration space (256K) */
>   		      <0x00 0x2a040000 0x0 0x00040000>, /* iATU_DMA reg space (256K)  */
> -		      <0x00 0x2a080000 0x0 0x00040000>; /* DBI reg space (256K)       */
> -		reg-names = "appl", "config", "atu_dma", "dbi";
> +		      <0x00 0x2a080000 0x0 0x00040000>, /* DBI reg space (256K)       */
> +		      <0x35 0x30000000 0x0 0x10000000>; /* ECAM (256MB)               */
> +		reg-names = "appl", "config", "atu_dma", "dbi", "ecam";

This generates warnings ...

arch/arm64/boot/dts/nvidia/tegra234-sim-vdk.dtb: pcie@...a0000: reg: [[0, 336199680, 0, 131072], [0, 704643072, 0, 262144], [0, 704905216, 0, 262144], [0, 705167360, 0, 262144], [53, 805306368, 0, 268435456]] is too long
	From schema: /home/jonathanh/workdir/tegra/korg-linux-next.git/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
arch/arm64/boot/dts/nvidia/tegra234-sim-vdk.dtb: pcie@...a0000: reg-names: ['appl', 'config', 'atu_dma', 'dbi', 'ecam'] is too long
	From schema: /home/jonathanh/workdir/tegra/korg-linux-next.git/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
arch/arm64/boot/dts/nvidia/tegra234-sim-vdk.dtb: pcie@...a0000: reg-names:4: 'ecam' is not one of ['dbi', 'dbi2', 'config', 'atu', 'atu_dma', 'app', 'appl', 'elbi', 'mgmt', 'ctrl', 'parf', 'cfg', 'link', 'ulreg', 'smu', 'mpu', 'apb', 'phy']
	From schema: /home/jonathanh/workdir/tegra/korg-linux-next.git/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
arch/arm64/boot/dts/nvidia/tegra234-sim-vdk.dtb: pcie@...a0000: Unevaluated properties are not allowed ('reg', 'reg-names', '#address-cells', '#size-cells', 'device_type', 'num-lanes', 'num-viewport', 'linux,pci-domain', '#interrupt-cells', 'interrupt-map-mask', 'interrupt-map', 'bus-range', 'ranges', 'iommu-map', 'iommu-map-mask' were unexpected)

We need to ensure that the new range is documented in Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml. Make sure you run ...

make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml

Jon

-- 
nvpublic