[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <37e3f35ab495ab26e506a5619172092c@somainline.org>
Date: Tue, 25 Oct 2022 23:01:55 +0300
From: Jami Kettunen <jami.kettunen@...ainline.org>
To: Caleb Connolly <caleb.connolly@...aro.org>
Cc: Alex Elder <elder@...aro.org>,
"David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Alex Elder <elder@...nel.org>,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] net: ipa: don't configure IDLE_INDICATION on v3.1
On 25.10.2022 02:48, Caleb Connolly wrote:
> IPA v3.1 doesn't support the IDLE_INDICATION_CFG register, this was
> causing a harmless splat in ipa_idle_indication_cfg(), add a version
> check to prevent trying to fetch this register on v3.1
>
> Fixes: 6a244b75cfab ("net: ipa: introduce ipa_reg()")
> Signed-off-by: Caleb Connolly <caleb.connolly@...aro.org>
Tested-by: Jami Kettunen <jami.kettunen@...ainline.org>
> ---
> This will need to wait for Jami's Tested-by as I don't have any v3.1
> hardware.
> ---
> drivers/net/ipa/ipa_main.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c
> index 3461ad3029ab..49537fccf6ad 100644
> --- a/drivers/net/ipa/ipa_main.c
> +++ b/drivers/net/ipa/ipa_main.c
> @@ -434,6 +434,9 @@ static void ipa_idle_indication_cfg(struct ipa
> *ipa,
> const struct ipa_reg *reg;
> u32 val;
>
> + if (ipa->version < IPA_VERSION_3_5_1)
> + return;
> +
> reg = ipa_reg(ipa, IDLE_INDICATION_CFG);
> val = ipa_reg_encode(reg, ENTER_IDLE_DEBOUNCE_THRESH,
> enter_idle_debounce_thresh);
Powered by blists - more mailing lists