linux-kernel - Re: [PATCH] maple_tree: Update copyright dates for test code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Oct 2022 13:40:19 -0700
From:   Joe Perches <joe@...ches.com>
To:     Liam Howlett <liam.howlett@...cle.com>
Cc:     "maple-tree@...ts.infradead.org" <maple-tree@...ts.infradead.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] maple_tree: Update copyright dates for test code

On Tue, 2022-10-25 at 20:23 +0000, Liam Howlett wrote:
> * Joe Perches <joe@...ches.com> [221025 14:06]:
> > On Tue, 2022-10-25 at 17:37 +0000, Liam Howlett wrote:
> > > Add the span to the year of the development.
[]
> > > diff --git a/tools/testing/radix-tree/maple.c b/tools/testing/radix-tree/maple.c
[]
> > > @@ -1,7 +1,8 @@
> > >  // SPDX-License-Identifier: GPL-2.0+
> > >  /*
> > > - * maple_tree.c: Userspace shim for maple tree test-suite
> > > - * Copyright (c) 2018 Liam R. Howlett <Liam.Howlett@...cle.com>
> > > + * maple_tree.c: Userspace testing for maple tree test-suite
> > > + * Copyright (c) 2018-2022 Oracle Corporation
> > > + * Author: Liam R. Howlett <Liam.Howlett@...cle.com>
> > 
> > Confused here.  Who owns the copyright from 2018?
> 
> 2018 should have also been oracle on this file.  Note the email
> address.

Noted.  It shows you as the copyright holder not Oracle Corp.

You are reassigning copyright yet the commit message merely shows
additional "span".

> > And what happened from 2019 through 2021 ?

When work on a object does not occur during a year, it
should not be included in a copyright "span".

> Development continued which is why I wanted to extend the date to a
> range.  I also presented the maple tree and spoke to a lot of people
> about it.  Also a pandemic, I hear.

Not a reason for copyright changes, but whatever...

> > $ git log --stat -p -1 54a611b605901c7d5d05b6b8f5d04a6ceb0962aa | grep -i copyright
> > + * Copyright (c) 2018-2022 Oracle
> > + * Copyright (c) 2018-2022 Oracle Corporation
> > + * Copyright (c) 2018 Liam R. Howlett <Liam.Howlett@...cle.com>
> 
> Right, this is what I am correcting.  I'm not sure what you are getting
> at here.

Just inconsistency.
First shows only Oracle, second is Oracle Corporation.

>  Did I do something incorrect with trying to fix my mistake?

Copyright reassignment not specified in commit message.

cheers, Joe