linux-kernel - Re: [PATCH v2 5/6] bnxt_en: Use auxiliary bus calls over proprietary calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202210260543.0m3bOvAM-lkp@intel.com>
Date:   Wed, 26 Oct 2022 05:18:11 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ajit Khaparde <ajit.khaparde@...adcom.com>
Cc:     oe-kbuild-all@...ts.linux.dev, andrew.gospodarek@...adcom.com,
        davem@...emloft.net, edumazet@...gle.com, jgg@...pe.ca,
        kuba@...nel.org, leon@...nel.org, linux-kernel@...r.kernel.org,
        linux-rdma@...r.kernel.org, michael.chan@...adcom.com,
        netdev@...r.kernel.org, pabeni@...hat.com,
        selvin.xavier@...adcom.com
Subject: Re: [PATCH v2 5/6] bnxt_en: Use auxiliary bus calls over proprietary
 calls

Hi Ajit,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.1-rc2 next-20221025]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ajit-Khaparde/bnxt_en-Add-auxiliary-driver-support/20221026-023141
patch link:    https://lore.kernel.org/r/20221025173110.33192-6-ajit.khaparde%40broadcom.com
patch subject: [PATCH v2 5/6] bnxt_en: Use auxiliary bus calls over proprietary calls
config: ia64-allyesconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/f04080c956abfeabf32961081d0401a800163d99
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Ajit-Khaparde/bnxt_en-Add-auxiliary-driver-support/20221026-023141
        git checkout f04080c956abfeabf32961081d0401a800163d99
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/infiniband/hw/bnxt_re/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/infiniband/hw/bnxt_re/main.c:1585:5: warning: no previous prototype for 'bnxt_re_suspend' [-Wmissing-prototypes]
    1585 | int bnxt_re_suspend(struct auxiliary_device *adev, pm_message_t state)
         |     ^~~~~~~~~~~~~~~
>> drivers/infiniband/hw/bnxt_re/main.c:1623:5: warning: no previous prototype for 'bnxt_re_resume' [-Wmissing-prototypes]
    1623 | int bnxt_re_resume(struct auxiliary_device *adev)
         |     ^~~~~~~~~~~~~~


vim +/bnxt_re_suspend +1585 drivers/infiniband/hw/bnxt_re/main.c

  1584	
> 1585	int bnxt_re_suspend(struct auxiliary_device *adev, pm_message_t state)
  1586	{
  1587		struct bnxt_re_dev *rdev = auxiliary_get_drvdata(adev);
  1588		struct bnxt *bp;
  1589	
  1590		if (!rdev)
  1591			return 0;
  1592	
  1593		mutex_lock(&bnxt_re_mutex);
  1594		/* L2 driver may invoke this callback during device error/crash or device
  1595		 * reset. Current RoCE driver doesn't recover the device in case of
  1596		 * error. Handle the error by dispatching fatal events to all qps
  1597		 * ie. by calling bnxt_re_dev_stop and release the MSIx vectors as
  1598		 * L2 driver want to modify the MSIx table.
  1599		 */
  1600		bp = netdev_priv(rdev->netdev);
  1601	
  1602		ibdev_info(&rdev->ibdev, "Handle device suspend call");
  1603		/* Check the current device state from L2 structure and move the
  1604		 * device to detached state if FW_FATAL_COND is set.
  1605		 * This prevents more commands to HW during clean-up,
  1606		 * in case the device is already in error.
  1607		 */
  1608		if (test_bit(BNXT_STATE_FW_FATAL_COND, &bp->state))
  1609			set_bit(ERR_DEVICE_DETACHED, &rdev->rcfw.cmdq.flags);
  1610	
  1611		bnxt_re_dev_stop(rdev);
  1612		bnxt_re_stop_irq(rdev);
  1613		/* Move the device states to detached and  avoid sending any more
  1614		 * commands to HW
  1615		 */
  1616		set_bit(BNXT_RE_FLAG_ERR_DEVICE_DETACHED, &rdev->flags);
  1617		set_bit(ERR_DEVICE_DETACHED, &rdev->rcfw.cmdq.flags);
  1618		mutex_unlock(&bnxt_re_mutex);
  1619	
  1620		return 0;
  1621	}
  1622	
> 1623	int bnxt_re_resume(struct auxiliary_device *adev)
  1624	{
  1625		struct bnxt_re_dev *rdev = auxiliary_get_drvdata(adev);
  1626	
  1627		if (!rdev)
  1628			return 0;
  1629	
  1630		mutex_lock(&bnxt_re_mutex);
  1631		/* L2 driver may invoke this callback during device recovery, resume.
  1632		 * reset. Current RoCE driver doesn't recover the device in case of
  1633		 * error. Handle the error by dispatching fatal events to all qps
  1634		 * ie. by calling bnxt_re_dev_stop and release the MSIx vectors as
  1635		 * L2 driver want to modify the MSIx table.
  1636		 */
  1637	
  1638		ibdev_info(&rdev->ibdev, "Handle device resume call");
  1639		mutex_unlock(&bnxt_re_mutex);
  1640	
  1641		return 0;
  1642	}
  1643	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Download attachment ".config.gz" of type "application/gzip" (75055 bytes)