linux-kernel - Re: [PATCH][next] net: dev: Convert sa_data to flexible array in struct sockaddr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <166673341646.9987.5803101009027995896.git-patchwork-notify@kernel.org>
Date:   Tue, 25 Oct 2022 21:30:16 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Kees Cook <keescook@...omium.org>
Cc:     kuba@...nel.org, davem@...emloft.net, edumazet@...gle.com,
        pabeni@...hat.com, axboe@...nel.dk, asml.silence@...il.com,
        dsahern@...nel.org, dylany@...com, yajun.deng@...ux.dev,
        petrm@...dia.com, liuhangbin@...il.com, leon@...nel.org,
        syzkaller@...glegroups.com, willemb@...gle.com,
        pablo@...filter.org, netdev@...r.kernel.org, nathan@...nel.org,
        ndesaulniers@...gle.com, trix@...hat.com,
        alibuda@...ux.alibaba.com, jk@...econstruct.com.au,
        bigeasy@...utronix.de, imagedong@...cent.com, kuniyu@...zon.com,
        liu3101@...due.edu, wsa+renesas@...g-engineering.com,
        william.xuanziyang@...wei.com, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev, linux-hardening@...r.kernel.org
Subject: Re: [PATCH][next] net: dev: Convert sa_data to flexible array in struct
 sockaddr

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@...nel.org>:

On Tue, 18 Oct 2022 02:56:03 -0700 you wrote:
> One of the worst offenders of "fake flexible arrays" is struct sockaddr,
> as it is the classic example of why GCC and Clang have been traditionally
> forced to treat all trailing arrays as fake flexible arrays: in the
> distant misty past, sa_data became too small, and code started just
> treating it as a flexible array, even though it was fixed-size. The
> special case by the compiler is specifically that sizeof(sa->sa_data)
> and FORTIFY_SOURCE (which uses __builtin_object_size(sa->sa_data, 1))
> do not agree (14 and -1 respectively), which makes FORTIFY_SOURCE treat
> it as a flexible array.
> 
> [...]

Here is the summary with links:
  - [next] net: dev: Convert sa_data to flexible array in struct sockaddr
    https://git.kernel.org/netdev/net-next/c/b5f0de6df6dc

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html