linux-kernel - Re: [PATCH V6 01/11] riscv: elf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0785930-8f2a-9d09-4dbf-545d11994cbe@huawei.com>
Date:   Tue, 25 Oct 2022 09:20:19 +0800
From:   "liaochang (A)" <liaochang1@...wei.com>
To:     <guoren@...nel.org>, <arnd@...db.de>, <palmer@...osinc.com>,
        <tglx@...utronix.de>, <peterz@...radead.org>, <luto@...nel.org>,
        <conor.dooley@...rochip.com>, <heiko@...ech.de>,
        <jszhang@...nel.org>, <lazyparser@...il.com>, <falcon@...ylab.org>,
        <chenhuacai@...nel.org>, <apatel@...tanamicro.com>,
        <atishp@...shpatra.org>, <palmer@...belt.com>,
        <paul.walmsley@...ive.com>, <mark.rutland@....com>,
        <zouyipeng@...wei.com>, <bigeasy@...utronix.de>,
        <David.Laight@...lab.com>, <chenzhongjin@...wei.com>
CC:     <linux-arch@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-riscv@...ts.infradead.org>,
        Guo Ren <guoren@...ux.alibaba.com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH V6 01/11] riscv: elf_kexec: Fixup compile warning



在 2022/10/2 9:24, guoren@...nel.org 写道:
> From: Guo Ren <guoren@...ux.alibaba.com>
> 
> If CRYTPO or CRYPTO_SHA256 or KEXE_FILE is not enabled, then:
> 
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1
> O=build_dir ARCH=riscv SHELL=/bin/bash arch/riscv/
> 
> ../arch/riscv/kernel/elf_kexec.c: In function 'elf_kexec_load':
> ../arch/riscv/kernel/elf_kexec.c:185:23: warning: variable
> 'kernel_start' set but not used [-Wunused-but-set-variable]
>   185 |         unsigned long kernel_start;
>       |                       ^~~~~~~~~~~~
> 
> Fixes: 838b3e28488f ("RISC-V: Load purgatory in kexec_file")
> Signed-off-by: Guo Ren <guoren@...ux.alibaba.com>
> Signed-off-by: Guo Ren <guoren@...nel.org>
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
> Reported-by: kernel test robot <lkp@...el.com>
> ---
>  arch/riscv/kernel/elf_kexec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/riscv/kernel/elf_kexec.c b/arch/riscv/kernel/elf_kexec.c
> index 0cb94992c15b..4b9264340b78 100644
> --- a/arch/riscv/kernel/elf_kexec.c
> +++ b/arch/riscv/kernel/elf_kexec.c
> @@ -198,7 +198,7 @@ static void *elf_kexec_load(struct kimage *image, char *kernel_buf,
>  	if (ret)
>  		goto out;
>  	kernel_start = image->start;
> -	pr_notice("The entry point of kernel at 0x%lx\n", image->start);
> +	pr_notice("The entry point of kernel at 0x%lx\n", kernel_start);
>  
>  	/* Add the kernel binary to the image */
>  	ret = riscv_kexec_elf_load(image, &ehdr, &elf_info,

LGTM

Reviewed-by: Liao Chang <liaochang1@...wei.com>

-- 
BR,
Liao, Chang