linux-kernel - Re: [PATCH] fs/exec.c: simplify initial stack size expansion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <166673667324.2128117.14471012472344174206.b4-ty@chromium.org>
Date:   Tue, 25 Oct 2022 15:24:39 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Al Viro <viro@...iv.linux.org.uk>, ebiederm@...ssion.com,
        eb@...ix.com
Cc:     Kees Cook <keescook@...omium.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] fs/exec.c: simplify initial stack size expansion

On Wed, 19 Oct 2022 09:32:35 +0200, Rolf Eike Beer wrote:
> I had a hard time trying to understand completely why it is using vm_end in
> one side of the expression and vm_start in the other one, and using
> something in the "if" clause that is not an exact copy of what is used
> below. The whole point is that the stack_size variable that was used in the
> "if" clause is the difference between vm_start and vm_end, which is not far
> away but makes this thing harder to read than it must be.
> 
> [...]

Applied to for-next/execve, thanks!

[1/1] fs/exec.c: simplify initial stack size expansion
      https://git.kernel.org/kees/c/bfb4a2b95875

-- 
Kees Cook