| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <c41b74ed595c33c4d3385aa2ae638e337b26337e.1666740522.git.tanjubrunostar0@gmail.com>
Date: Tue, 25 Oct 2022 23:37:09 +0000
From: Tanjuate Brunostar <tanjubrunostar0@...il.com>
To: gregkh@...uxfoundation.org
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
outreachy@...ts.linux.dev,
Tanjuate Brunostar <tanjubrunostar0@...il.com>
Subject: [PATCH 13/17] staging: vt6655: changed variable name: bNeedACK
change variable names bDisCRC to meet the
linux coding standard, as it says to avoid using camelCase naming
style. Cought by checkpatch
Signed-off-by: Tanjuate Brunostar <tanjubrunostar0@...il.com>
---
drivers/staging/vt6655/rxtx.c | 36 +++++++++++++++++------------------
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
index cc3b642ef8af..1704b63da2cd 100644
--- a/drivers/staging/vt6655/rxtx.c
+++ b/drivers/staging/vt6655/rxtx.c
@@ -102,7 +102,7 @@ static void s_vgenerate_tx_parameter(struct vnt_private *p_device,
void *pv_rts,
void *pv_cts,
unsigned int cb_frame_size,
- bool bNeedACK,
+ bool b_need_ack,
unsigned int uDMAIdx,
void *psEthHeader,
unsigned short wCurrentRate);
@@ -927,7 +927,7 @@ static void s_vFillCTSHead(struct vnt_private *p_device,
* pv_rts - RTS Buffer
* pCTS - CTS Buffer
* cb_frame_size - Transmit Data Length (Hdr+Payload+FCS)
- * bNeedACK - If need ACK
+ * b_need_ack - If need ACK
* uDescIdx - Desc Index
* Out:
* none
@@ -944,7 +944,7 @@ static void s_vgenerate_tx_parameter(struct vnt_private *p_device,
void *pv_rts,
void *pv_cts,
unsigned int cb_frame_size,
- bool bNeedACK,
+ bool b_need_ack,
unsigned int uDMAIdx,
void *psEthHeader,
unsigned short wCurrentRate)
@@ -979,30 +979,30 @@ static void s_vgenerate_tx_parameter(struct vnt_private *p_device,
cb_frame_size, wCurrentRate);
buf->rrv_time_a = vnt_rxtx_rsvtime_le16(p_device, by_pkt_type,
cb_frame_size,
- wCurrentRate, bNeedACK);
+ wCurrentRate, b_need_ack);
buf->rrv_time_b = vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11B,
cb_frame_size,
p_device->byTopCCKBasicRate,
- bNeedACK);
+ b_need_ack);
- s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cb_frame_size, bNeedACK,
+ s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cb_frame_size, b_need_ack,
b_dis_crc, psEthHeader, wCurrentRate, by_fb_option);
} else {/* RTS_needless, PCF mode */
struct vnt_rrv_time_cts *buf = pv_rrv_time;
buf->rrv_time_a = vnt_rxtx_rsvtime_le16(p_device, by_pkt_type,
cb_frame_size,
- wCurrentRate, bNeedACK);
+ wCurrentRate, b_need_ack);
buf->rrv_time_b = vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11B,
cb_frame_size,
p_device->byTopCCKBasicRate,
- bNeedACK);
+ b_need_ack);
buf->cts_rrv_time_ba = get_rtscts_time(p_device, 3, by_pkt_type,
cb_frame_size, wCurrentRate);
/* Fill CTS */
s_vFillCTSHead(p_device, uDMAIdx, by_pkt_type, pv_cts, cb_frame_size,
- bNeedACK, b_dis_crc, wCurrentRate, by_fb_option);
+ b_need_ack, b_dis_crc, wCurrentRate, by_fb_option);
}
} else if (by_pkt_type == PK_TYPE_11A) {
if (pv_rts) {/* RTS_need, non PCF mode */
@@ -1011,16 +1011,16 @@ static void s_vgenerate_tx_parameter(struct vnt_private *p_device,
buf->rts_rrv_time = get_rtscts_time(p_device, 2, by_pkt_type, cb_frame_size,
wCurrentRate);
buf->rrv_time = vnt_rxtx_rsvtime_le16(p_device, by_pkt_type, cb_frame_size,
- wCurrentRate, bNeedACK);
+ wCurrentRate, b_need_ack);
/* Fill RTS */
- s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cb_frame_size, bNeedACK,
+ s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cb_frame_size, b_need_ack,
b_dis_crc, psEthHeader, wCurrentRate, by_fb_option);
} else if (!pv_rts) {/* RTS_needless, non PCF mode */
struct vnt_rrv_time_ab *buf = pv_rrv_time;
buf->rrv_time = vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11A, cb_frame_size,
- wCurrentRate, bNeedACK);
+ wCurrentRate, b_need_ack);
}
} else if (by_pkt_type == PK_TYPE_11B) {
if (pv_rts) {/* RTS_need, non PCF mode */
@@ -1029,16 +1029,16 @@ static void s_vgenerate_tx_parameter(struct vnt_private *p_device,
buf->rts_rrv_time = get_rtscts_time(p_device, 0, by_pkt_type, cb_frame_size,
wCurrentRate);
buf->rrv_time = vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11B, cb_frame_size,
- wCurrentRate, bNeedACK);
+ wCurrentRate, b_need_ack);
/* Fill RTS */
- s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cb_frame_size, bNeedACK,
+ s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cb_frame_size, b_need_ack,
b_dis_crc, psEthHeader, wCurrentRate, by_fb_option);
} else { /* RTS_needless, non PCF mode */
struct vnt_rrv_time_ab *buf = pv_rrv_time;
buf->rrv_time = vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11B, cb_frame_size,
- wCurrentRate, bNeedACK);
+ wCurrentRate, b_need_ack);
}
}
}
@@ -1065,7 +1065,7 @@ static unsigned int s_cbFillTxBufHead(struct vnt_private *p_device,
unsigned int uMACfragNum = 1;
unsigned int uPadding = 0;
unsigned int cbReqCount = 0;
- bool bNeedACK = (bool)(fifo_ctl & FIFOCTL_NEEDACK);
+ bool b_need_ack = (bool)(fifo_ctl & FIFOCTL_NEEDACK);
bool bRTS = (bool)(fifo_ctl & FIFOCTL_RTS);
struct vnt_tx_desc *ptdCurr;
unsigned int cbHeaderLength = 0;
@@ -1229,10 +1229,10 @@ static unsigned int s_cbFillTxBufHead(struct vnt_private *p_device,
/* Fill FIFO,RrvTime,RTS,and CTS */
s_vgenerate_tx_parameter(p_device, by_pkt_type, tx_buffer_head, pv_rrv_time, pv_rts, pv_cts,
- cb_frame_size, bNeedACK, uDMAIdx, hdr, p_device->wCurrentRate);
+ cb_frame_size, b_need_ack, uDMAIdx, hdr, p_device->wCurrentRate);
/* Fill DataHead */
uDuration = s_uFillDataHead(p_device, by_pkt_type, pvTxDataHd, cb_frame_size, uDMAIdx,
- bNeedACK, 0, 0, uMACfragNum, by_fb_option,
+ b_need_ack, 0, 0, uMACfragNum, by_fb_option,
p_device->wCurrentRate, is_pspoll);
hdr->duration_id = uDuration;
--
2.34.1
Powered by blists - more mailing lists