linux-kernel - Re: [PATCH v19 1/2] fpga: lattice-sysconfig-spi: add Lattice sysCONFIG FPGA manager

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y1dZT5Ta7AcMKeH5@yilunxu-OptiPlex-7050>
Date:   Tue, 25 Oct 2022 11:34:39 +0800
From:   Xu Yilun <yilun.xu@...el.com>
To:     Ivan Bornyakov <i.bornyakov@...rotek.ru>
Cc:     mdf@...nel.org, hao.wu@...el.com, trix@...hat.com, dg@...ix.com,
        j.zink@...gutronix.de, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, linux-fpga@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...gutronix.de, system@...rotek.ru
Subject: Re: [PATCH v19 1/2] fpga: lattice-sysconfig-spi: add Lattice
 sysCONFIG FPGA manager

On 2022-10-20 at 09:52:29 +0800, Xu Yilun wrote:
> On 2022-10-19 at 12:10:14 +0300, Ivan Bornyakov wrote:
> > Add support to the FPGA manager for programming Lattice ECP5 FPGA over
> > slave SPI sysCONFIG interface.
> > 
> > sysCONFIG interface core functionality is separate from both ECP5 and
> > SPI specifics, so support for other FPGAs with different port types can
> > be added in the future.
> > 
> > Signed-off-by: Ivan Bornyakov <i.bornyakov@...rotek.ru>

[...]
 
> > +static int sysconfig_spi_bitstream_burst_init(struct sysconfig_priv *priv)
> > +{
> > +	const u8 lsc_bitstream_burst[] = SYSCONFIG_LSC_BITSTREAM_BURST;
> > +	struct spi_device *spi = to_spi_device(priv->dev);
> > +	struct spi_transfer xfer = {};
> > +	struct spi_message msg;
> > +	size_t buf_len;
> > +	void *buf;
> > +	int ret;
> > +
> > +	buf_len = sizeof(lsc_bitstream_burst);
> > +
> > +	buf = kmalloc(buf_len, GFP_KERNEL);
> > +	if (!buf)
> > +		return -ENOMEM;
> > +
> > +	memcpy(buf, lsc_bitstream_burst, buf_len);

Could you help fix this lkp issue and I could re-apply the patch?

  config: arm-randconfig-c034-20221024 (attached as .config)
  compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0

  If you fix the issue, kindly add following tag where applicable
  | Reported-by: kernel test robot <lkp@...el.com>

  cocci warnings: (new ones prefixed by >>)
  >> drivers/fpga/lattice-sysconfig-spi.c:33:7-14: WARNING opportunity for kmemdup


Thanks,
Yilun