[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y1eChJS/0aEchtpH@kadam>
Date: Tue, 25 Oct 2022 09:30:28 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Jernej Skrabec <jernej.skrabec@...il.com>
Cc: mripard@...nel.org, paul.kocialkowski@...tlin.com,
mchehab@...nel.org, gregkh@...uxfoundation.org, wens@...e.org,
samuel@...lland.org, hverkuil-cisco@...all.nl,
linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/11] media: cedrus: Add helper for checking capabilities
On Mon, Oct 24, 2022 at 10:15:08PM +0200, Jernej Skrabec wrote:
> There is several different Cedrus cores with varying capabilities, so
> some operations like listing formats depends on checks if feature is
> supported or not.
>
> Currently check for capabilities is only in format enumeration helper,
> but it will be used also elsewhere later. Let's convert this check to
> helper and while at it, also simplify it. There is no need to check if
> capability mask is zero, condition will still work properly.
Sure. That's true. Out of curiousity, can cedrus_formats[i].capabilities
be zero? Because it feels like that's what should be checked.
regards,
dan carpenter
Powered by blists - more mailing lists