[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bfae3198-7557-f984-200c-2c677881f462@kernel.org>
Date: Tue, 25 Oct 2022 15:01:14 +0800
From: Chao Yu <chao@...nel.org>
To: Yangtao Li <frank.li@...o.com>, jaegeuk@...nel.org
Cc: linux-f2fs-devel@...ts.sourceforge.net,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] f2fs: remove redundant return in
f2fs_create_flush_cmd_control()
On 2022/10/24 21:59, Yangtao Li wrote:
> Replace
> if (A) {
> ......
> return err;
> }
> return err;
> with
> if (A) {
> ......
> }
> return err;
>
> Signed-off-by: Yangtao Li <frank.li@...o.com>
> ---
> fs/f2fs/segment.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index acf3d3fa4363..f6f16d691226 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -647,7 +647,6 @@ int f2fs_create_flush_cmd_control(struct f2fs_sb_info *sbi)
> err = PTR_ERR(fcc->f2fs_issue_flush);
> kfree(fcc);
> SM_I(sbi)->fcc_info = NULL;
> - return err;
> }
>
> return err;
It may looks more clean if it return 0 here?
Thanks,
Powered by blists - more mailing lists