linux-kernel - Re: [PATCH Part2 v6 12/49] crypto: ccp: Add support to initialize the AMD-SP for SEV-SNP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1enOIfS3nnlcyyc@zn.tnic>
Date:   Tue, 25 Oct 2022 11:07:04 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     "Kalra, Ashish" <ashish.kalra@....com>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        linux-coco@...ts.linux.dev, linux-mm@...ck.org,
        linux-crypto@...r.kernel.org, tglx@...utronix.de, mingo@...hat.com,
        jroedel@...e.de, thomas.lendacky@....com, hpa@...or.com,
        ardb@...nel.org, pbonzini@...hat.com, seanjc@...gle.com,
        vkuznets@...hat.com, jmattson@...gle.com, luto@...nel.org,
        dave.hansen@...ux.intel.com, slp@...hat.com, pgonda@...gle.com,
        peterz@...radead.org, srinivas.pandruvada@...ux.intel.com,
        rientjes@...gle.com, dovmurik@...ux.ibm.com, tobin@....com,
        michael.roth@....com, vbabka@...e.cz, kirill@...temov.name,
        ak@...ux.intel.com, tony.luck@...el.com, marcorr@...gle.com,
        sathyanarayanan.kuppuswamy@...ux.intel.com, alpergun@...gle.com,
        dgilbert@...hat.com, jarkko@...nel.org
Subject: Re: [PATCH Part2 v6 12/49] crypto: ccp: Add support to initialize
 the AMD-SP for SEV-SNP

On Wed, Oct 19, 2022 at 01:48:48PM -0500, Kalra, Ashish wrote:
> I see that other drivers are also using the same convention:

It is only convention. Look at the .rst output:

0 if the SEV successfully processed the command
-``ENODEV``    if the SEV device is not available
-``ENOTSUPP``  if the SEV does not support SEV
-``ETIMEDOUT`` if the SEV command timed out
-``EIO``       if the SEV returned a non-zero return code

vs

0 if the SEV successfully processed the command
``-ENODEV``    if the SEV device is not available
``-ENOTSUPP``  if the SEV does not support SEV
``-ETIMEDOUT`` if the SEV command timed out
``-EIO``       if the SEV returned a non-zero return code

so in the html output of this, the minus sign will be displayed either
with text font or with monospaced font as part of the error type.

I wanna say the second is better as the '-' is part of the error code
but won't waste too much time debating this. :)

Btw

$ ./scripts/kernel-doc include/linux/psp-sev.h

complains a lot. Might wanna fix those up when bored or someone else
who's reading this and feels bored too. :-)

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette