linux-kernel - Re: [PATCH] clocksource/drivers/arm_arch_timer: Fix event stream param in Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86pmegdwug.wl-maz@kernel.org>
Date:   Tue, 25 Oct 2022 11:24:55 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Tyler Hicks <code@...icks.com>
Cc:     Mark Rutland <mark.rutland@....com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Vijay Balakrishna <vijayb@...ux.microsoft.com>,
        Will Deacon <will@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clocksource/drivers/arm_arch_timer: Fix event stream param in Kconfig

Hi Tyler,

On Mon, 24 Oct 2022 20:51:18 +0100,
Tyler Hicks <code@...icks.com> wrote:
> 
> From: "Tyler Hicks (Microsoft)" <code@...icks.com>
> 
> Fix the event stream timer command line parameter name that's documented
> in the Kconfig description for CONFIG_ARM_ARCH_TIMER_EVTSTREAM. It
> didn't match the command line parameter name that's actually honored in
> the source code.
> 
> Reported-by: Vijay Balakrishna <vijayb@...ux.microsoft.com>
> Fixes: 46fd5c6b3059 ("clocksource/drivers/arm_arch_timer: Control the evtstrm via the cmdline")
> Cc: stable@...r.kernel.org

No, this really doesn't deserve a Cc: stable. This bit may be wrong,
but we have the correct information in the kernel-parameters.txt file,
which is authoritative AFAIC.

> Signed-off-by: Tyler Hicks (Microsoft) <code@...icks.com>
> ---
>  drivers/clocksource/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 4469e7f555e9..dcc274460973 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -315,7 +315,7 @@ config ARM_ARCH_TIMER_EVTSTREAM
>  	  executing the wfe instruction at a frequency represented as a
>  	  power-of-2 divisor of the clock rate. The behaviour can also be
>  	  overridden on the command line using the
> -	  clocksource.arm_arch_timer.evtstream parameter.
> +	  clocksource.arm_arch_timer.evtstrm parameter.
>  	  The main use of the event stream is wfe-based timeouts of userspace
>  	  locking implementations. It might also be useful for imposing timeout
>  	  on wfe to safeguard against any programming errors in case an expected

With this tag dropped,

Acked-by: Marc Zyngier <maz@...nel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.