linux-kernel - Re: [PATCH] mmc: sdhci-brcmstb: Allow building with COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a1549d5-7407-7e47-5fbe-bcb9ca953cda@intel.com>
Date:   Tue, 25 Oct 2022 14:08:36 +0300
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Brian Norris <briannorris@...omium.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Florian Fainelli <f.fainelli@...il.com>
Cc:     Al Cooper <alcooperx@...il.com>, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>, linux-mmc@...r.kernel.org
Subject: Re: [PATCH] mmc: sdhci-brcmstb: Allow building with COMPILE_TEST

On 24/10/22 21:17, Brian Norris wrote:
> This driver is pretty simple, and it can be useful to build it (for
> validation purposes) without BMIPS or ARCH_BRCMSTB.
> 
> It technically depends on CONFIG_OF to do anything useful at runtime,
> but it still works out OK for compile-testing using the !OF stubs.
> 
> Signed-off-by: Brian Norris <briannorris@...omium.org>

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
> 
>  drivers/mmc/host/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index f324daadaf70..453fba8d2d9d 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -1040,10 +1040,10 @@ config MMC_SDHCI_MICROCHIP_PIC32
>  
>  config MMC_SDHCI_BRCMSTB
>  	tristate "Broadcom SDIO/SD/MMC support"
> -	depends on ARCH_BRCMSTB || BMIPS_GENERIC
> +	depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
>  	depends on MMC_SDHCI_PLTFM
>  	select MMC_CQHCI
> -	default y
> +	default ARCH_BRCMSTB || BMIPS_GENERIC
>  	help
>  	  This selects support for the SDIO/SD/MMC Host Controller on
>  	  Broadcom STB SoCs.