linux-kernel - Re: [PATCH] ACPI: x86: Add another system to quirk list for forcing StorageD3Enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f80828d-4c8c-f98f-24e9-68f5c886dd40@amd.com>
Date:   Mon, 24 Oct 2022 19:13:10 -0500
From:   "Limonciello, Mario" <mario.limonciello@....com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Dell.Client.Kernel@...l.com,
        Julius Brockmann <mail@...iusbrockmann.com>,
        Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPI: x86: Add another system to quirk list for forcing
 StorageD3Enable

On 10/14/2022 07:11, Mario Limonciello wrote:
> commit 018d6711c26e4 ("ACPI: x86: Add a quirk for Dell Inspiron 14 2-in-1
> for StorageD3Enable") introduced a quirk to allow a system with ambiguous
> use of _ADR 0 to force StorageD3Enable.
> 
> Julius Brockmann reports that Inspiron 16 5625 suffers that same symptoms.
> Add this other system to the list as well.
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216440
> Reported-and-tested-by: Julius Brockmann <mail@...iusbrockmann.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> ---
>   drivers/acpi/x86/utils.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 

Hi Rafael,

This got sent near the merge window a few weeks ago.  It's a trivial fix 
so I just want to make sure it didn't get misplaced.

Thanks!

> diff --git a/drivers/acpi/x86/utils.c b/drivers/acpi/x86/utils.c
> index f8a2cbdc0ce2b..d7d3f1669d4c0 100644
> --- a/drivers/acpi/x86/utils.c
> +++ b/drivers/acpi/x86/utils.c
> @@ -219,6 +219,12 @@ static const struct dmi_system_id force_storage_d3_dmi[] = {
>   			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 14 7425 2-in-1"),
>   		}
>   	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 16 5625"),
> +		}
> +	},
>   	{}
>   };
>