linux-kernel - Re: [PATCH] video: fbdev: sis: use explicitly signed char

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Oct 2022 14:55:36 +0200
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Helge Deller <deller@....de>
Cc:     linux-kernel@...r.kernel.org,
        Thomas Winischhofer <thomas@...ischhofer.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-fbdev@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] video: fbdev: sis: use explicitly signed char

On Mon, Oct 24, 2022 at 8:29 PM Helge Deller <deller@....de> wrote:
>
> On 10/24/22 18:29, Jason A. Donenfeld wrote:
> > With char becoming unsigned by default, and with `char` alone being
> > ambiguous and based on architecture, signed chars need to be marked
> > explicitly as such. This fixes warnings like:
> >
> > drivers/video/fbdev/sis/init301.c:3549 SiS_GetCRT2Data301() warn: 'SiS_Pr->SiS_EModeIDTable[ModeIdIndex]->ROMMODEIDX661' is unsigned
> >
> > Cc: Thomas Winischhofer <thomas@...ischhofer.net>
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Cc: Helge Deller <deller@....de>
> > Cc: linux-usb@...r.kernel.org
> > Cc: linux-fbdev@...r.kernel.org
> > Cc: dri-devel@...ts.freedesktop.org
> > Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>
>
> Applied to linux-fbdev git tree.

For 6.1 as a fix, right? Since this is already broken on, e.g., ARM.

Jason