linux-kernel - Re: [PATCH v3 1/7] mmc: cqhci: Provide helper for resetting both SDHCI and CQHCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de5186fb-e176-23df-63fc-2a436e765c14@intel.com>
Date:   Tue, 25 Oct 2022 16:09:06 +0300
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Brian Norris <briannorris@...omium.org>,
        Ulf Hansson <ulf.hansson@...aro.org>
Cc:     Shawn Lin <shawn.lin@...k-chips.com>, linux-mmc@...r.kernel.org,
        Al Cooper <alcooperx@...il.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Sowjanya Komatineni <skomatineni@...dia.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Thierry Reding <thierry.reding@...il.com>,
        Fabio Estevam <festevam@...il.com>,
        Michal Simek <michal.simek@...inx.com>,
        linux-kernel@...r.kernel.org, Shawn Guo <shawnguo@...nel.org>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        linux-arm-msm@...r.kernel.org, Haibo Chen <haibo.chen@....com>,
        Andy Gross <agross@...nel.org>,
        linux-arm-kernel@...ts.infradead.org,
        Faiz Abbas <faiz_abbas@...com>,
        Jonathan Hunter <jonathanh@...dia.com>, stable@...r.kernel.org
Subject: Re: [PATCH v3 1/7] mmc: cqhci: Provide helper for resetting both
 SDHCI and CQHCI

On 24/10/22 20:54, Brian Norris wrote:
> Several SDHCI drivers need to deactivate command queueing in their reset
> hook (see sdhci_cqhci_reset() / sdhci-pci-core.c, for example), and
> several more are coming.
> 
> Those reset implementations have some small subtleties (e.g., ordering
> of initialization of SDHCI vs. CQHCI might leave us resetting with a
> NULL ->cqe_private), and are often identical across different host
> drivers.
> 
> We also don't want to force a dependency between SDHCI and CQHCI, or
> vice versa; non-SDHCI drivers use CQHCI, and SDHCI drivers might support
> command queueing through some other means.
> 
> So, implement a small helper, to avoid repeating the same mistakes in
> different drivers. Simply stick it in a header, because it's so small it
> doesn't deserve its own module right now, and inlining to each driver is
> pretty reasonable.
> 
> This is marked for -stable, as it is an important prerequisite patch for
> several SDHCI controller bugfixes that follow.
> 
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Brian Norris <briannorris@...omium.org>

One cosmetic nit, otherwise:

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
> 
> Changes in v3:
>  - New in v3 (replacing a simple 'cqe_private == NULL' patch in v2)
> 
>  drivers/mmc/host/sdhci-cqhci.h | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>  create mode 100644 drivers/mmc/host/sdhci-cqhci.h
> 
> diff --git a/drivers/mmc/host/sdhci-cqhci.h b/drivers/mmc/host/sdhci-cqhci.h
> new file mode 100644
> index 000000000000..270ab1f1de3c
> --- /dev/null
> +++ b/drivers/mmc/host/sdhci-cqhci.h
> @@ -0,0 +1,25 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Copyright 2022 The Chromium OS Authors
> + *
> + * Support that applies to the combination of SDHCI and CQHCI, while not
> + * expressing a dependency between the two modules.
> + */
> +
> +#ifndef __MMC_HOST_SDHCI_CQHCI_H__
> +#define __MMC_HOST_SDHCI_CQHCI_H__
> +
> +#include "cqhci.h"
> +#include "sdhci.h"
> +
> +static inline void sdhci_and_cqhci_reset(struct sdhci_host *host, u8 mask)
> +{
> +	if ((host->mmc->caps2 & MMC_CAP2_CQE) && (mask & SDHCI_RESET_ALL) &&
> +	    host->mmc->cqe_private)
> +		cqhci_deactivate(host->mmc);
> +
> +	sdhci_reset(host, mask);
> +}
> +
> +

Double blank line

> +#endif /* __MMC_HOST_SDHCI_CQHCI_H__ */