[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <84028e30-22c1-10bf-f444-d3ac8429a003@gmail.com>
Date: Wed, 26 Oct 2022 12:44:14 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Brian Norris <briannorris@...omium.org>,
Ulf Hansson <ulf.hansson@...aro.org>
Cc: Shawn Guo <shawnguo@...nel.org>, linux-mmc@...r.kernel.org,
Adrian Hunter <adrian.hunter@...el.com>,
Shawn Lin <shawn.lin@...k-chips.com>,
Michal Simek <michal.simek@...inx.com>,
Sascha Hauer <s.hauer@...gutronix.de>,
Bjorn Andersson <andersson@...nel.org>,
Thierry Reding <thierry.reding@...il.com>,
linux-arm-msm@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@...adcom.com>,
Jonathan Hunter <jonathanh@...dia.com>,
Andy Gross <agross@...nel.org>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
linux-kernel@...r.kernel.org,
Konrad Dybcio <konrad.dybcio@...ainline.org>,
Al Cooper <alcooperx@...il.com>,
Fabio Estevam <festevam@...il.com>,
NXP Linux Team <linux-imx@....com>,
Haibo Chen <haibo.chen@....com>,
Sowjanya Komatineni <skomatineni@...dia.com>,
stable@...r.kernel.org
Subject: Re: [PATCH v4 1/7] mmc: cqhci: Provide helper for resetting both
SDHCI and CQHCI
On 10/26/22 12:42, Brian Norris wrote:
> Several SDHCI drivers need to deactivate command queueing in their reset
> hook (see sdhci_cqhci_reset() / sdhci-pci-core.c, for example), and
> several more are coming.
>
> Those reset implementations have some small subtleties (e.g., ordering
> of initialization of SDHCI vs. CQHCI might leave us resetting with a
> NULL ->cqe_private), and are often identical across different host
> drivers.
>
> We also don't want to force a dependency between SDHCI and CQHCI, or
> vice versa; non-SDHCI drivers use CQHCI, and SDHCI drivers might support
> command queueing through some other means.
>
> So, implement a small helper, to avoid repeating the same mistakes in
> different drivers. Simply stick it in a header, because it's so small it
> doesn't deserve its own module right now, and inlining to each driver is
> pretty reasonable.
>
> This is marked for -stable, as it is an important prerequisite patch for
> several SDHCI controller bugfixes that follow.
>
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Brian Norris <briannorris@...omium.org>
> Acked-by: Adrian Hunter <adrian.hunter@...el.com>
Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
--
Florian
Powered by blists - more mailing lists