linux-kernel - [PATCH 2/4] soc: qcom: pmic_glink: Introduce base PMIC GLINK driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1666813946-21569-1-git-send-email-quic_subbaram@quicinc.com>
Date:   Wed, 26 Oct 2022 12:52:26 -0700
From:   Subbaraman Narayanamurthy <quic_subbaram@...cinc.com>
To:     <bjorn.andersson@...aro.org>
CC:     <agross@...nel.org>, <devicetree@...r.kernel.org>,
        <konrad.dybcio@...ainline.org>,
        <krzysztof.kozlowski+dt@...aro.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-pm@...r.kernel.org>, <robh+dt@...nel.org>, <sre@...nel.org>
Subject: [PATCH 2/4] soc: qcom: pmic_glink: Introduce base PMIC GLINK driver

> +static struct pmic_glink *__pmic_glink;
> +static DEFINE_MUTEX(__pmic_glink_lock);

Having this global device and lock to update pmic_glink struct pointer
might not work well if there are multiple pmic_glink devices that
corresponds to multiple pmic_glink channels (or rpmsg devices). This
is fine for the primary pmic_glink channel that supports mission mode
clients. However, to support debugging, there could be a secondary
pmic_glink channel and some clients under it.

> +struct pmic_glink_client {
> +	struct list_head node;
> +
> +	struct pmic_glink *pmic;

It would be good to name this pointer as "pg" or something.