linux-kernel - Re: [PATCH] block: fix Werror=format with GCC 13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 27 Oct 2022 04:11:40 +0800
From:   kernel test robot <lkp@...el.com>
To:     Martin Liška <mliska@...e.cz>,
        linux-kernel@...r.kernel.org
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        linux-block@...r.kernel.org, axboe@...nel.dk
Subject: Re: [PATCH] block: fix Werror=format with GCC 13

Hi Martin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on axboe-block/for-next]
[also build test WARNING on linus/master v6.1-rc2 next-20221026]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Martin-Li-ka/block-fix-Werror-format-with-GCC-13/20221025-045756
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
patch link:    https://lore.kernel.org/r/f70c7a11-e81e-f6b9-a403-315117f4aa3a%40suse.cz
patch subject: [PATCH] block: fix Werror=format with GCC 13
config: x86_64-randconfig-a012
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/f341dda9dc3f582b49fcf0ef0b5aa24e975ccc43
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Martin-Li-ka/block-fix-Werror-format-with-GCC-13/20221025-045756
        git checkout f341dda9dc3f582b49fcf0ef0b5aa24e975ccc43
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> block/blk-iocost.c:3037:37: warning: format specifies type 'unsigned long' but the argument has type 'unsigned int' [-Wformat]
                   seq_printf(sf, "%s %lu\n", dname, iocg->cfg_weight / WEIGHT_ONE);
                                      ~~~            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                      %u
   block/blk-iocost.c:3047:34: warning: format specifies type 'unsigned long' but the argument has type 'unsigned int' [-Wformat]
           seq_printf(sf, "default %lu\n", iocc->dfl_weight / WEIGHT_ONE);
                                   ~~~     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                   %u
   2 warnings generated.


vim +3037 block/blk-iocost.c

  3029	
  3030	static u64 ioc_weight_prfill(struct seq_file *sf, struct blkg_policy_data *pd,
  3031				     int off)
  3032	{
  3033		const char *dname = blkg_dev_name(pd->blkg);
  3034		struct ioc_gq *iocg = pd_to_iocg(pd);
  3035	
  3036		if (dname && iocg->cfg_weight)
> 3037			seq_printf(sf, "%s %lu\n", dname, iocg->cfg_weight / WEIGHT_ONE);
  3038		return 0;
  3039	}
  3040	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (164785 bytes)