linux-kernel - Re: [peterz-queue:sched/core 16/18] kernel/sched/psi.c:983:35: error: too few arguments to function call, expected 3, have 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJuCfpHn45rzqAbNuz_Q9AUXcirEDN_PrzG-inGYiOyM9Tw8+A@mail.gmail.com>
Date:   Wed, 26 Oct 2022 16:44:26 -0700
From:   Suren Baghdasaryan <surenb@...gle.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     kernel test robot <lkp@...el.com>, llvm@...ts.linux.dev,
        oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [peterz-queue:sched/core 16/18] kernel/sched/psi.c:983:35: error:
 too few arguments to function call, expected 3, have 2

On Wed, Oct 26, 2022 at 11:28 AM Suren Baghdasaryan <surenb@...gle.com> wrote:
>
> On Wed, Oct 26, 2022 at 2:21 AM Peter Zijlstra <peterz@...radead.org> wrote:
> >
> > On Wed, Oct 26, 2022 at 09:58:58AM +0800, kernel test robot wrote:
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/core
> > > head:   7005e3c43be6b6297440e85cb7d8c12a94540b49
> > > commit: 95a70934458341dc43db09be8e7b88c98fba9b89 [16/18] psi: stop relying on timer_pending for poll_work rescheduling
> > > config: i386-randconfig-a004-20221024 (attached as .config)
> > > compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
> > > reproduce (this is a W=1 build):
> > >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > >         chmod +x ~/bin/make.cross
> > >         # https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?id=95a70934458341dc43db09be8e7b88c98fba9b89
> > >         git remote add peterz-queue https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git
> > >         git fetch --no-tags peterz-queue sched/core
> > >         git checkout 95a70934458341dc43db09be8e7b88c98fba9b89
> > >         # save the config file
> > >         mkdir build_dir && cp config build_dir/.config
> > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
> > >
> > > If you fix the issue, kindly add following tag where applicable
> > > | Reported-by: kernel test robot <lkp@...el.com>
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > >    In file included from kernel/sched/build_utility.c:97:
> > > >> kernel/sched/psi.c:983:35: error: too few arguments to function call, expected 3, have 2
> > >                            psi_schedule_poll_work(group, 1);
> > >                            ~~~~~~~~~~~~~~~~~~~~~~         ^
> > >    kernel/sched/psi.c:568:13: note: 'psi_schedule_poll_work' declared here
> > >    static void psi_schedule_poll_work(struct psi_group *group, unsigned long delay,
> > >                ^
> > >    1 error generated.
> > >
> > >
> >
> > Droping for now; Suren could you fix up and repost please?
>
> Sorry, I missed the report. Will post a fix by EOD. Thanks!

Hi Peter,
I posted the new v5 patch with the one-line fix at
https://lore.kernel.org/all/20221026233839.1934419-1-surenb@google.com.
I didn't notice the issue because that path is only used when
CONFIG_IRQ_TIME_ACCOUNTING is enabled, which I haven't tested :(
Please try picking it now. I think nothing should fail this time
around (famous last words).
Thanks,
Suren.