linux-kernel - Re: [PATCH v2 1/2] usb: serial: add support for CH348

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <65ed2576-55a4-fbf1-010b-a51e92389062@suse.com>
Date:   Wed, 26 Oct 2022 10:02:32 +0200
From:   Oliver Neukum <oneukum@...e.com>
To:     Corentin LABBE <clabbe@...libre.com>,
        Oliver Neukum <oneukum@...e.com>
Cc:     gregkh@...uxfoundation.org, johan@...nel.org,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        neil.armstrong@...aro.org
Subject: Re: [PATCH v2 1/2] usb: serial: add support for CH348



On 26.10.22 09:44, Corentin LABBE wrote:

Hi,


> 
> Thanks for your review, I will fix them all.

I am happy to point out issues.

>> [..]
>>
>>> +
>>> +static int ch348_fixup_port_bulk_in(struct ch348 *ch348, struct usb_serial_port *port)
>>> +{
>>> +	int i;
>>> +
>>> +	/* Already Initialized */
>>> +	if (port->bulk_in_size) {
>>
>> BTW, shouldn't these be unsigned int?
> 
> I dont understand what you mean here.

bulk_in_size as a member of the structure is defined as int.
As a size cannot meaningfully be negative and this takes no
error reports, I was wondering whether it should be declared
an unsigned integer for the sake of cleanliness.

	Regards
		Oliver