linux-kernel - Re: [PATCH v2 1/1] KVM: s390: vsie: clarifications on setting the APCB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 26 Oct 2022 10:18:06 +0200
From:   Pierre Morel <pmorel@...ux.ibm.com>
To:     Claudio Imbrenda <imbrenda@...ux.ibm.com>
Cc:     David Hildenbrand <david@...hat.com>, kvm@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        borntraeger@...ibm.com, frankja@...ux.ibm.com, cohuck@...hat.com,
        thuth@...hat.com, hca@...ux.ibm.com, gor@...ux.ibm.com,
        svens@...ux.ibm.com
Subject: Re: [PATCH v2 1/1] KVM: s390: vsie: clarifications on setting the
 APCB



On 10/25/22 18:20, Claudio Imbrenda wrote:
> On Tue, 25 Oct 2022 15:17:36 +0200
> Pierre Morel <pmorel@...ux.ibm.com> wrote:
> 
>> On 10/25/22 11:30, David Hildenbrand wrote:
>>> On 25.10.22 11:13, Pierre Morel wrote:
>>>> The APCB is part of the CRYCB.
>>>> The calculation of the APCB origin can be done by adding
>>>> the APCB offset to the CRYCB origin.
>>>>
>>>> Current code makes confusing transformations, converting
>>>> the CRYCB origin to a pointer to calculate the APCB origin.
>>>>   
>>>
>>>
>>> While at it, can we rename "crycb_o" to "crycb_gpa" and "apcb_o" to
>>> "apcb_gpa".
>>>
>>> These are not pointers but guest physical addresses.
>>>    
>>
>> I can do that.
>> the _o came from the name in the documentation "origin"
>> but gpa is more obvious.
>>
> 
> with that fixed:
> 
> Reviewed-by: Claudio Imbrenda <imbrenda@...ux.ibm.com>

Thanks,
Pierre

-- 
Pierre Morel
IBM Lab Boeblingen