linux-kernel - Re: [PATCH v2 2/6] RDMA/bnxt_re: Use auxiliary driver interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1j8wv9nn6MmdlcB@unreal>
Date:   Wed, 26 Oct 2022 12:24:18 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Ajit Khaparde <ajit.khaparde@...adcom.com>
Cc:     andrew.gospodarek@...adcom.com, davem@...emloft.net,
        edumazet@...gle.com, jgg@...pe.ca, kuba@...nel.org,
        linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org,
        michael.chan@...adcom.com, netdev@...r.kernel.org,
        pabeni@...hat.com, selvin.xavier@...adcom.com
Subject: Re: [PATCH v2 2/6] RDMA/bnxt_re: Use auxiliary driver interface

On Tue, Oct 25, 2022 at 10:31:06AM -0700, Ajit Khaparde wrote:
> Use auxiliary driver interface for driver load, unload ROCE driver.
> The driver does not need to register the interface using the netdev
> notifier anymore. Removed the bnxt_re_dev_list which is not needed.
> Currently probe, remove and shutdown ops have been implemented for
> the auxiliary device.
> 
> Signed-off-by: Ajit Khaparde <ajit.khaparde@...adcom.com>
> Reviewed-by: Andy Gospodarek <andrew.gospodarek@...adcom.com>
> ---
>  drivers/infiniband/hw/bnxt_re/bnxt_re.h       |   9 +-
>  drivers/infiniband/hw/bnxt_re/main.c          | 387 +++++++-----------
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c     |  64 ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c |  67 ++-
>  drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h |   3 +
>  5 files changed, 214 insertions(+), 316 deletions(-)

<...>

> -static struct bnxt_en_dev *bnxt_re_dev_probe(struct net_device *netdev)
> +static struct bnxt_en_dev *bnxt_re_dev_probe(struct auxiliary_device *adev)
>  {
> -	struct bnxt_en_dev *en_dev;
> +	struct bnxt_aux_dev *aux_dev =
> +		container_of(adev, struct bnxt_aux_dev, aux_dev);
> +	struct bnxt_en_dev *en_dev = NULL;
>  	struct pci_dev *pdev;
>  
> -	en_dev = ((struct bnxt*)netdev_priv(netdev))->edev;
> -	if (IS_ERR(en_dev))
> -		return en_dev;
> +	if (aux_dev)
> +		en_dev = aux_dev->edev;
> +
> +	if (!en_dev)
> +		return NULL;

Thank you for working to convert this driver to auxiliary bus. I'm
confident that it will be ready soon.

In order to effectively review this series, you need to structure
patches in such way that you don't remove in patch X+1 code that you
added in patch X.

Also you should remove maze of redundant functions that do nothing, but
just call to another function with useless checks.

Auxiliary devices shouldn't be created if en_dev == NULL.

Thanks