linux-kernel - Re: [PATCH v2 tty-next 1/3] 8250: microchip: pci1xxxx: Add driver for quad-uart support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c9c19aebb2bf28bad7e98c4d8365ea81ec58bc08.camel@microchip.com>
Date:   Wed, 26 Oct 2022 11:12:27 +0000
From:   <Tharunkumar.Pasumarthi@...rochip.com>
To:     <jk@...abs.org>, <christophe.jaillet@...adoo.fr>,
        <Kumaravel.Thiagarajan@...rochip.com>,
        <gregkh@...uxfoundation.org>, <ilpo.jarvinen@...ux.intel.com>,
        <wander@...hat.com>, <u.kleine-koenig@...gutronix.de>,
        <etremblay@...tech-controls.com>, <macro@...am.me.uk>,
        <jirislaby@...nel.org>, <johan@...nel.org>,
        <andy.shevchenko@...il.com>, <geert+renesas@...der.be>,
        <phil.edworthy@...esas.com>, <lukas@...ner.de>
CC:     <linux-serial@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH v2 tty-next 1/3] 8250: microchip: pci1xxxx: Add driver for
 quad-uart support.

On Mon, 2022-10-03 at 21:36 +0200, Christophe JAILLET wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> > +             }
> > +             priv->line[i] = serial8250_register_8250_port(&uart);
> 
> In case of error, this should be undone in an error handling path in the
> probe, as done in the remove() function below.
> 
> If we break, we still continue and return success. But the last
> priv->line[i] are still 0. Is it an issue when pci1xxxx_serial_remove()
> is called?

This will not cause a problem in pci1xxxx_serial_remove as this condition 'priv-
>line[i] >= 0' will be checked for each of the ports before calling
serial8250_unregister_port API.


Thanks,
Tharun Kumar P