linux-kernel - Re: [PATCH] mmc: sdhci_am654: 'select', not 'depends' REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 26 Oct 2022 13:25:38 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Brian Norris <briannorris@...omium.org>
Cc:     YueHaibing <yuehaibing@...wei.com>, linux-kernel@...r.kernel.org,
        linux-mmc@...r.kernel.org
Subject: Re: [PATCH] mmc: sdhci_am654: 'select', not 'depends' REGMAP_MMIO

On Mon, 24 Oct 2022 at 20:03, Brian Norris <briannorris@...omium.org> wrote:
>
> REGMAP_MMIO is not user-configurable, so we can only satisfy this
> dependency by enabling some other Kconfig symbol that properly 'select's
> it.
>
> Use select like everybody else.
>
> Noticed when trying to enable this driver for compile testing.
>
> Fixes: 59592cc1f593 ("mmc: sdhci_am654: Add dependency on MMC_SDHCI_AM654")
> Signed-off-by: Brian Norris <briannorris@...omium.org>

Applied for fixes and by adding a stable tag, thanks!

Kind regards
Uffe


> ---
>
>  drivers/mmc/host/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index f324daadaf70..fb1062a6394c 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -1075,9 +1075,10 @@ config MMC_SDHCI_OMAP
>
>  config MMC_SDHCI_AM654
>         tristate "Support for the SDHCI Controller in TI's AM654 SOCs"
> -       depends on MMC_SDHCI_PLTFM && OF && REGMAP_MMIO
> +       depends on MMC_SDHCI_PLTFM && OF
>         select MMC_SDHCI_IO_ACCESSORS
>         select MMC_CQHCI
> +       select REGMAP_MMIO
>         help
>           This selects the Secure Digital Host Controller Interface (SDHCI)
>           support present in TI's AM654 SOCs. The controller supports
> --
> 2.38.0.135.g90850a2211-goog
>