linux-kernel - Re: [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8670e757-7275-57eb-3f5c-0a21ba354e37@nvidia.com>
Date:   Wed, 26 Oct 2022 12:39:13 +0100
From:   Jon Hunter <jonathanh@...dia.com>
To:     Bjorn Helgaas <helgaas@...nel.org>, lpieralisi@...nel.org
Cc:     Vidya Sagar <vidyas@...dia.com>, jingoohan1@...il.com,
        gustavo.pimentel@...opsys.com, robh@...nel.org, kw@...ux.com,
        bhelgaas@...gle.com, treding@...dia.com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, kthota@...dia.com,
        mmaddireddy@...dia.com, sagar.tv@...il.com,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event
 logging

Hi Lorenzo,

On 18/10/2022 17:43, Bjorn Helgaas wrote:
> On Tue, Oct 18, 2022 at 07:21:54AM +0100, Jon Hunter wrote:
>> Hi Bjorn,
>>
>> On 13/09/2022 11:12, Vidya Sagar wrote:
>>> Some of the platforms (like Tegra194 and Tegra234) have open slots and
>>> not having an endpoint connected to the slot is not an error.
>>> So, changing the macro from dev_err to dev_info to log the event.
>>>
>>> Signed-off-by: Vidya Sagar <vidyas@...dia.com>
>>> ---
>>>    drivers/pci/controller/dwc/pcie-designware.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
>>> index 650a7f22f9d0..25154555aa7a 100644
>>> --- a/drivers/pci/controller/dwc/pcie-designware.c
>>> +++ b/drivers/pci/controller/dwc/pcie-designware.c
>>> @@ -456,7 +456,7 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci)
>>>    	}
>>>    	if (retries >= LINK_WAIT_MAX_RETRIES) {
>>> -		dev_err(pci->dev, "Phy link never came up\n");
>>> +		dev_info(pci->dev, "Phy link never came up\n");
>>>    		return -ETIMEDOUT;
>>>    	}
>>
>>
>> Are you OK to take this change?
> 
> When this came up, Lorenzo was in the middle of a big move and I was
> covering for him while he was unavailable.  But he's back, and I'm
> sure he will resolve this soon.
> 
> Personally I'm OK either way.
> 
> Bjorn


Can we come to a conclusion on this?

We have tests that fail when errors/warning messages are reported. We 
can choose to ignore these errors, but given that this is not an error 
in this case, we were thinking it is better to make it informational.

Thanks
Jon

-- 
nvpublic