linux-kernel - Re: [net-next v3 2/6] net: dcb: add new apptrust attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1kmBMXluPI1Wmu/@DEN-LT-70577>
Date:   Wed, 26 Oct 2022 12:10:23 +0000
From:   <Daniel.Machon@...rochip.com>
To:     <petrm@...dia.com>
CC:     <netdev@...r.kernel.org>, <davem@...emloft.net>,
        <maxime.chevallier@...tlin.com>, <thomas.petazzoni@...tlin.com>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <Lars.Povlsen@...rochip.com>, <Steen.Hegelund@...rochip.com>,
        <UNGLinuxDriver@...rochip.com>, <joe@...ches.com>,
        <linux@...linux.org.uk>, <Horatiu.Vultur@...rochip.com>,
        <Julia.Lawall@...ia.fr>, <vladimir.oltean@....com>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [net-next v3 2/6] net: dcb: add new apptrust attribute

> > +     if (ops->dcbnl_getapptrust) {
> > +             u8 selectors[IEEE_8021QAZ_APP_SEL_MAX + 1] = {0};
> > +             int nselectors;
> > +
> > +             apptrust = nla_nest_start(skb, DCB_ATTR_DCB_APP_TRUST_TABLE);
> > +             if (!app)
> > +                     return -EMSGSIZE;
> > +
> > +             err = ops->dcbnl_getapptrust(netdev, selectors, &nselectors);
> > +             if (err)
> > +                     return -EMSGSIZE;
> 
> This should return the error coming from the driver instead of
> -EMSGSIZE.

Hmm. The question is whether we should return at all if dcbnl_getapptrust()
fails, or just continue to fill whatever other ieee information is available?
Seems to be like the rest of the code in ieee_fill() just ignore that error.

> 
> Also, it should cancel the nest before returning.

Ack.