linux-kernel - Re: [PATCH 02/17] staging: vt6655: changed variable names: s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1k7nY8LnibU5lMh@kroah.com>
Date:   Wed, 26 Oct 2022 15:52:29 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Tanjuate Brunostar <tanjubrunostar0@...il.com>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        outreachy@...ts.linux.dev
Subject: Re: [PATCH 02/17] staging: vt6655: changed variable names:
 s_vFillRTSHead

On Tue, Oct 25, 2022 at 11:36:58PM +0000, Tanjuate Brunostar wrote:
>     change variable names s_vFillRTSHead and wTimeStampOff to meet the
>     linux coding standard, as it says to avoid using camelCase naming style.
>     Cought by checkpatch

s_vFillRTSHead is not a variable name.  It is a function name, and ick,
that's a horrid name, please make it sane (i.e. do NOT put the type of
the function in the name like they did here.)

thanks,

greg k-h