linux-kernel - Re: [PATCH] KVM: s390: pci: Fix allocation size of aift kzdev elements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2609dbde-c779-fae2-989a-4512687125f5@linux.ibm.com>
Date:   Wed, 26 Oct 2022 16:54:27 +0200
From:   Janosch Frank <frankja@...ux.ibm.com>
To:     Matthew Rosato <mjrosato@...ux.ibm.com>,
        Rafael Mendonca <rafaelmendsr@...il.com>,
        Eric Farman <farman@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Claudio Imbrenda <imbrenda@...ux.ibm.com>,
        David Hildenbrand <david@...hat.com>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>
Cc:     linux-s390@...r.kernel.org, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: s390: pci: Fix allocation size of aift kzdev
 elements

On 10/26/22 15:36, Matthew Rosato wrote:
> On 10/25/22 9:32 PM, Rafael Mendonca wrote:
>> The 'kzdev' field of struct 'zpci_aift' is an array of pointers to
>> 'kvm_zdev' structs. Allocate the proper size accordingly.
>>
>> Reported by Coccinelle:
>>    WARNING: Use correct pointer type argument for sizeof
>>
>> Fixes: 98b1d33dac5f ("KVM: s390: pci: do initial setup for AEN interpretation")
>> Signed-off-by: Rafael Mendonca <rafaelmendsr@...il.com>
> 
> Thanks for reporting & fixing.
> 
> Reviewed-by: Matthew Rosato <mjrosato@...ux.ibm.com>

After consulting Matt I've put this into the CI and I'll pick it once it 
received a bit of coverage.