linux-kernel - Re: [PATCH] Fixed[ERROR:trailing whitespace and braces around scalar initializer]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221026171430.GA5592@nam-dell>
Date:   Wed, 26 Oct 2022 19:14:34 +0200
From:   Nam Cao <namcaov@...il.com>
To:     UMWARI JOVIAL <umwarijovial@...il.com>
Cc:     gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, outreachy@...ts.linux.dev
Subject: Re: [PATCH] Fixed[ERROR:trailing whitespace and braces around scalar
 initializer]

On Wed, Oct 26, 2022 at 04:28:38PM +0300, UMWARI JOVIAL wrote:
> Using the checkpatch.pl script, found the below errors and  fixed
> ERROR: trailing whitespace
> CHECK: Please don't use multiple blank lines
> warning: braces around scalar initializer
> 
> Signed-off-by: UMWARI JOVIAL <umwarijovial@...il.com>
> ---
>  drivers/staging/most/dim2/dim2.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c
> index 7a5f80e637a0..28259ce05024 100644
> --- a/drivers/staging/most/dim2/dim2.c
> +++ b/drivers/staging/most/dim2/dim2.c
> @@ -987,7 +987,6 @@ static int rcar_gen2_enable(struct platform_device *pdev)
>  		writel(0x04, dev->io_base + 0x600);
>  	}
>  
> -
>  	/* BBCR = 0b11 */
>  	writel(0x03, dev->io_base + 0x500);
>  	writel(0x0002FF02, dev->io_base + 0x508);
> @@ -1084,7 +1083,6 @@ static const struct of_device_id dim2_of_match[] = {
>  	{
>  		.compatible = "xlnx,axi4-os62420_6pin-1.00.a",
>  	},
> -	{},

I'm no expert, but this looks like a null terminator and probably
should not be removed.

Best regards,
Nam