linux-kernel - Re: [PATCH] ARM: dts: lan966x: Enable sgpio on pcb8291

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221026173813.wdpueueziirxdgq5@soft-dev3-1>
Date:   Wed, 26 Oct 2022 19:38:13 +0200
From:   Horatiu Vultur - M31836 <Horatiu.Vultur@...rochip.com>
To:     Claudiu Beznea - M18063 <Claudiu.Beznea@...rochip.com>
CC:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        Nicolas Ferre - M43238 <Nicolas.Ferre@...rochip.com>,
        UNGLinuxDriver <UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH] ARM: dts: lan966x: Enable sgpio on pcb8291

The 10/26/2022 07:47, Claudiu Beznea - M18063 wrote:
> Hi, Horatiu,

Hi Claudiu,

> 
> On 19.10.2022 10:51, Horatiu Vultur wrote:
> > Enable sgpio node on pcb8291 as this is needed to be able to control
> > the LEDs on this board. Otherwise the LEDs support on the board will
> > not be available.
> 
> Do we need a fixes tag for this?

I was not 100% sure that I need to add the tag, but I will send
another version where I will add the tag.

> 
> > On the other board pcb8309 the sgpio is already enabled because it
> > needed to access the SFP ports.
> > 
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>
> > ---
> >  arch/arm/boot/dts/lan966x-pcb8291.dts | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
> > index f4f054cdf2a87..3a3d76af86122 100644
> > --- a/arch/arm/boot/dts/lan966x-pcb8291.dts
> > +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
> > @@ -69,6 +69,12 @@ can0_b_pins:  can0-b-pins {
> >  		pins = "GPIO_35", "GPIO_36";
> >  		function = "can0_b";
> >  	};
> > +
> > +	sgpio_a_pins: sgpio-a-pins {
> > +		/* SCK, D0, D1, LD */
> > +		pins = "GPIO_32", "GPIO_33", "GPIO_34", "GPIO_35";
> > +		function = "sgpio_a";
> > +	};
> >  };
> >  
> >  &can0 {
> > @@ -118,6 +124,20 @@ &serdes {
> >  	status = "okay";
> >  };
> >  
> > +&sgpio {
> > +	pinctrl-0 = <&sgpio_a_pins>;
> > +	pinctrl-names = "default";
> > +	microchip,sgpio-port-ranges = <0 3>, <8 11>;
> > +	status = "okay";
> > +
> > +	gpio@0 {
> > +		ngpios = <64>;
> > +	};
> > +	gpio@1 {
> > +		ngpios = <64>;
> > +	};
> > +};
> > +
> >  &switch {
> >  	status = "okay";
> >  };
> 

-- 
/Horatiu