linux-kernel - Re: [PATCH v2 1/2] ARM: nspire: Use syscon-reboot to handle restart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e25a5f89-42bb-f97b-4b84-e7609ee00139@ti.com>
Date:   Thu, 27 Oct 2022 13:16:19 -0500
From:   Andrew Davis <afd@...com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Arnd Bergmann <arnd@...db.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Daniel Tang <dt.tangr@...il.com>,
        Fabian Vogt <fabian@...ter-vogt.de>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] ARM: nspire: Use syscon-reboot to handle restart

On 10/26/22 3:17 PM, Krzysztof Kozlowski wrote:
> On 26/10/2022 12:13, Andrew Davis wrote:
>> Writing this bit can be handled by the syscon-reboot driver. Add the
>> info to DT and remove the machine_desc version.
>>
>> Signed-off-by: Andrew Davis <afd@...com>
>> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
>> ---
>>   arch/arm/boot/dts/nspire.dtsi |  7 +++++++
> 
> DTS cannot go with code.
> 
> Additionally, this breaks people's filtering as there is no "dts" prefix
> in the subject.
> 
>>   arch/arm/mach-nspire/Kconfig  |  2 ++
>>   arch/arm/mach-nspire/mmio.h   |  3 ---
>>   arch/arm/mach-nspire/nspire.c | 10 ----------
>>   4 files changed, 9 insertions(+), 13 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/nspire.dtsi b/arch/arm/boot/dts/nspire.dtsi
>> index bb240e6a3a6f..6357b803521e 100644
>> --- a/arch/arm/boot/dts/nspire.dtsi
>> +++ b/arch/arm/boot/dts/nspire.dtsi
>> @@ -172,7 +172,14 @@ rtc: rtc@...90000 {
>>   			};
>>   
>>   			misc: misc@...a0000 {
>> +				compatible = "syscon", "simple-mfd";
> 
> These are not allowed on their own (need specific compatible) and you
> should have warnings when running dtbs_check.
> 

Ah, my bad, must have gotten lost in the other existing warnings.
Sent v3 with the above fixes, and tried to remove some existing warnings.

Thanks,
Andrew

> Best regards,
> Krzysztof
>