linux-kernel - Re: [PATCH -next] pinctrl: qcom: Include bitfield.h in pinctrl-lpass-lpi.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1rcUbCVJi7QhcFK@smile.fi.intel.com>
Date:   Thu, 27 Oct 2022 22:30:25 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Nathan Chancellor <nathan@...nel.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, patches@...ts.linux.dev
Subject: Re: [PATCH -next] pinctrl: qcom: Include bitfield.h in
 pinctrl-lpass-lpi.c

On Thu, Oct 27, 2022 at 12:16:25PM -0700, Nathan Chancellor wrote:
> When building ARCH=arm allmodconfig, the following error occurs:
> 
>   drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function ‘lpi_gpio_set_mux’:
>   drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:102:9: error: implicit declaration of function ‘u32p_replace_bits’ [-Werror=implicit-function-declaration]
>     102 |         u32p_replace_bits(&val, i, LPI_GPIO_FUNCTION_MASK);
>         |         ^~~~~~~~~~~~~~~~~
>   drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function ‘lpi_config_get’:
>   drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:127:16: error: implicit declaration of function ‘FIELD_GET’ [-Werror=implicit-function-declaration]
>     127 |         pull = FIELD_GET(LPI_GPIO_PULL_MASK, ctl_reg);
>         |                ^~~~~~~~~
>   drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function ‘lpi_config_set’:
>   drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:233:23: error: implicit declaration of function ‘u32_encode_bits’ [-Werror=implicit-function-declaration]
>     233 |                 val = u32_encode_bits(value ? 1 : 0, LPI_GPIO_VALUE_OUT_MASK);
>         |                       ^~~~~~~~~~~~~~~
>   cc1: all warnings being treated as errors
> 
> bitfield.h was included via pinctrl-lpass-lpi.h but another change
> removed that include to restrict what was being included. Add bitfield.h
> back to pinctrl-lpass-lpi.c, as it is needed there.

Thanks, https://lore.kernel.org/linux-gpio/20221027184145.2533-1-andriy.shevchenko@linux.intel.com/

-- 
With Best Regards,
Andy Shevchenko