linux-kernel - Re: [PATCH 2/2] staging: rtl8192u: remove unused macro definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1rdEE8HBb9CVwlq@ubunlion>
Date:   Fri, 28 Oct 2022 01:03:36 +0530
From:   Deepak R Varma <drv@...lo.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     outreachy@...ts.linux.dev, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging: rtl8192u: remove unused macro definition

On Wed, Oct 26, 2022 at 03:55:01PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Oct 26, 2022 at 07:14:43PM +0530, Deepak R Varma wrote:
> > On Wed, Oct 26, 2022 at 03:14:23PM +0200, Greg Kroah-Hartman wrote:
> > > On Wed, Oct 26, 2022 at 08:58:44AM +0530, Deepak R Varma wrote:
> > > > Pre-processor macros that are defined but are never used should be
> > > > cleaned up to avoid unexpected usage.
> > > >
> > > > Signed-off-by: Deepak R Varma <drv@...lo.com>
> > > > ---
> > > >  drivers/staging/rtl8192u/ieee80211/ieee80211.h | 2 --
> > > >  1 file changed, 2 deletions(-)
> > > >
> > > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> > > > index 00c07455cbb3..0b3dda59d7c0 100644
> > > > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> > > > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> > > > @@ -230,8 +230,6 @@ struct cb_desc {
> > > >  #define ieee80211_unregister_crypto_ops ieee80211_unregister_crypto_ops_rsl
> > > >  #define ieee80211_get_crypto_ops	ieee80211_get_crypto_ops_rsl
> > > >
> > > > -#define ieee80211_ccmp_null		ieee80211_ccmp_null_rsl
> > > > -
> > > >  #define free_ieee80211			free_ieee80211_rsl
> > > >  #define alloc_ieee80211			alloc_ieee80211_rsl
> > >
> > > These #defines are a mess, please look into unwinding them as they
> > > should not be needed at all.
> >
> > Hello Greg,
> > I would like to know what you mean by "unwind them". Is there a documentation or past
> > commit that I can review to understand the expectations better?
>
> Look at them and try to figure out why they are there, and then work to
> remove them entirely.  A define like this is very odd in the kernel, it
> should not be needed at all, right?

Hello Greg,
I will look into these additional macros soon and send any further edits as a
separate patch (set). Is the current patch set with 2 patches acceptable?

Also, I am trying to get Coccinelle to work on my machine. Trying to work
through strange issues. I will work on the macro unwinding task you suggested
once a get the Coccinelle task completed.

Thank you,
./drv

>
> thanks,
>
> greg k-h
>