linux-kernel - Re: [PATCHv2 1/1] dt-bindings: net: snps,dwmac: Document queue config subnodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e28b84fa-8830-65ad-24b9-bd64410fe4ab@linaro.org>
Date:   Thu, 27 Oct 2022 15:50:32 -0400
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Sebastian Reichel <sebastian.reichel@...labora.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Jose Abreu <joabreu@...opsys.com>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...labora.com
Subject: Re: [PATCHv2 1/1] dt-bindings: net: snps,dwmac: Document queue config
 subnodes

On 27/10/2022 12:31, Sebastian Reichel wrote:
> The queue configuration is referenced by snps,mtl-rx-config and
> snps,mtl-tx-config. Some in-tree DTs and the example put the
> referenced config nodes directly beneath the root node, but
> most in-tree DTs put it as child node of the dwmac node.
> 
> This adds proper description for this setup, which has the
> advantage of validating the queue configuration node content.
> 
> The example is also updated to use the sub-node style, incl.
> the axi bus configuration node, which got the same treatment
> as the queues config in 5361660af6d3 ("dt-bindings: net: snps,dwmac:
> Document stmmac-axi-config subnode").
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>
> ---
> Changes since PATCHv1:
>  * https://lore.kernel.org/all/20221021171055.85888-1-sebastian.reichel@collabora.com/
>  * add logic to make booleans that are actually enums mutually exclusive
>  * fix type of "snps,send_slope", "snps,idle_slope", "snps,high_credit" and "snps,low_credit"
>  * add missing 'additionalProperties: false' in rx-queues-config -> "^queue[0-9]$"
>  * add missing 'additionalProperties: false' in tx-queues-config -> "^queue[0-9]$"
>  * update example to follow the sub-node style

Uh, this grew big... Thanks for fixing it.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof