linux-kernel - Re: [PATCH v3 08/17] ufs: core: mcq: Allocate memory for mcq mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18ef5dff-141c-7d23-6930-8bd5a9871e3e@acm.org>
Date:   Thu, 27 Oct 2022 14:38:31 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Asutosh Das <quic_asutoshd@...cinc.com>, quic_cang@...cinc.com,
        martin.petersen@...cle.com, linux-scsi@...r.kernel.org
Cc:     quic_nguyenb@...cinc.com, quic_xiaosenh@...cinc.com,
        stanley.chu@...iatek.com, eddie.huang@...iatek.com,
        daejun7.park@...sung.com, avri.altman@....com, mani@...nel.org,
        beanhuo@...ron.com, quic_richardp@...cinc.com,
        linux-arm-msm@...r.kernel.org,
        Alim Akhtar <alim.akhtar@...sung.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Kiwoong Kim <kwmad.kim@...sung.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 08/17] ufs: core: mcq: Allocate memory for mcq mode

On 10/20/22 11:03, Asutosh Das wrote:
>   int ufshcd_mcq_init(struct ufs_hba *hba)
>   {
> -	int ret;
> +	int ret, i;
> +	struct ufs_hw_queue *hwq;

Although this is not a strict rule, most kernel developers these days 
order declarations from longer to shorter ("reverse Christmas tree").

> +	/* The very first HW queue is to serve device command */

is to serve -> serves
command -> commands

Otherwise this patch looks good to me.

Thanks,

Bart.