linux-kernel - Re: [PATCH 4/4] clk: Warn if we register a mux without determine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Oct 2022 14:45:07 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     maxime@...no.tech
Cc:     Michael Turquette <mturquette@...libre.com>,
        linux-kernel@...r.kernel.org,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        linux-clk@...r.kernel.org
Subject: Re: [PATCH 4/4] clk: Warn if we register a mux without determine_rate

Quoting maxime@...no.tech (2022-10-26 06:52:15)
> On Tue, Oct 25, 2022 at 07:07:58PM -0700, Stephen Boyd wrote:
> > 
> > You can grep for it:
> > 
> >  $ git grep -W 'struct clk_ops .*='
> 
> TIL about -W. It's awesome, thanks

:)

> 
> > but I'm fairly certain a coccinelle script can detect most of these
> > because clk_ops are usually statically defined (although not always).
> > 
> > Either way I already see that 'owl_comp_div_ops' will trigger this
> > warning. And 'at91sam9x5_smd_ops' looks even more likely. Given that I'm
> > not super keen on applying this patch.
> 
> It's the reason why I didn't return an error at first, I wanted to
> report that it's invalid and let to drivers the chance to be fixed
> still.
> 
> Should I take your above comment as you'd rather have the affected
> drivers fixed in this patch and we then return an error, or is it that
> you don't want that patch at all?

You can try fixing all the drivers that are failing to meet this
requirement (found with grep) and if they are fixed we can start
printing the warning. That seems to be the practical approach to getting
this patch accepted. The TODO irks me to be honest. I'd rather we fix
everything and make it an error and be done with it.