linux-kernel - Re: [PATCH 0/5] Parse the PCIE AER structure and set to relevant registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221027220931.GA843829@bhelgaas>
Date:   Thu, 27 Oct 2022 17:09:31 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     LeoLiu-oc <LeoLiu-oc@...oxin.com>
Cc:     rafael@...nel.org, lenb@...nel.org, james.morse@....com,
        tony.luck@...el.com, bp@...en8.de, robert.moore@...el.com,
        ying.huang@...el.com, rdunlap@...radead.org, bhelgaas@...gle.com,
        linux-acpi@...r.kernel.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, devel@...ica.org,
        CobeChen@...oxin.com, TonyWWang@...oxin.com, ErosZhang@...oxin.com
Subject: Re: [PATCH 0/5] Parse the PCIE AER structure and set to relevant
 registers

On Thu, Oct 27, 2022 at 11:14:58AM +0800, LeoLiu-oc wrote:
> From: leoliu-oc <leoliu-oc@...oxin.com>
> 
> HEST PCIE AER error source information describes the Uncorrectable Error 
> Severity, CorrectableError Mask and other aer register's value to write to the
> bridge's Correctable Error Mask register.

I guess the point is to extract register values from HEST PCI Express
AER structures (ACPI r6.5, sec 18.3.2.4, etc.) and program them into
AER Capabilities?

> leoliu-oc (5):
>   ACPI/APEI: Add apei_hest_parse_aer()
>   ACPI/APEI: remove static from apei_hest_parse()
>   ACPI/PCI: Add AER bits #defines for PCIE/PCI-X bridges
>   ACPI/PCI: Add pci_acpi_program_hest_aer_params()
>   ACPI/PCI: config pcie devices's aer register

If/when you repost this, it would be nice if the patches ([1/5],
[2/5], etc) were responses to the cover letter ([0/5]).  Since they're
not responses, b4 doesn't know they're connected and can't grab the
whole series at once.

Also capitalize the subject lines consistently and s/PCIE/PCIe/ and
s/pcie/PCIe/ and s/aer/AER/, e.g.,

  ACPI/APEI: Add apei_hest_parse_aer()
  ACPI/APEI: Remove static from apei_hest_parse()
  PCI: Add AER #defines for PCIe/PCI-X bridges
  ACPI/PCI: Add pci_acpi_program_hest_aer_params()
  ACPI/PCI: Configure devices AER registers based on HEST

>  drivers/acpi/apei/hest.c      | 121 +++++++++++++++++++++++++++++++++-
>  drivers/pci/pci-acpi.c        |  92 ++++++++++++++++++++++++++
>  drivers/pci/pci.h             |   5 ++
>  drivers/pci/probe.c           |   1 +
>  include/acpi/actbl1.h         |  69 +++++++++++++++++++
>  include/acpi/apei.h           |   9 +++
>  include/uapi/linux/pci_regs.h |   5 ++
>  7 files changed, 300 insertions(+), 2 deletions(-)
> 
> -- 
> 2.20.1
>