linux-kernel - Re: [PATCH 5/6] clk: imx: keep hsio bus clock always on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20221027230910.4AF58C43470@smtp.kernel.org>
Date:   Thu, 27 Oct 2022 16:09:08 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Peng Fan (OSS) <peng.fan@....nxp.com>, abel.vesa@...aro.org,
        abelvesa@...nel.org, festevam@...il.com, kernel@...gutronix.de,
        krzysztof.kozlowski+dt@...aro.org, mturquette@...libre.com,
        robh+dt@...nel.org, s.hauer@...gutronix.de, shawnguo@...nel.org
Cc:     linux-imx@....com, linux-clk@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, Jacky Bai <ping.bai@....com>,
        Peng Fan <peng.fan@....com>
Subject: Re: [PATCH 5/6] clk: imx: keep hsio bus clock always on

Quoting Peng Fan (OSS) (2022-10-27 03:11:58)
> From: Jacky Bai <ping.bai@....com>
> 
> During Linux System suspend/resume stress test after System Sleep
> enabled, system will stuck sometimes. It is because NICMIX is powered
> down, which HSIOMIX(always on) is not powered down. When NICMIX
> powering down, HSIOMIX will get a hardware handshake, without HSIO ROOT
> clk, the handshake will lose. Then after NICMIX power on when system
> resume, the access to HSIOMIX through NICMIX would be broken. So keep HSIO
> ROOT always on.
> 
> Reviewed-by: Peng Fan <peng.fan@....com>
> Signed-off-by: Jacky Bai <ping.bai@....com>
>  [Peng Fan] rewrite commit message
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
>  drivers/clk/imx/clk-imx93.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c
> index 422ad3c89845..74e8d810db7f 100644
> --- a/drivers/clk/imx/clk-imx93.c
> +++ b/drivers/clk/imx/clk-imx93.c
> @@ -109,7 +109,7 @@ static const struct imx93_clk_root {
>         { IMX93_CLK_CCM_CKO2,           "ccm_cko2_root",        0x1d00, CKO2_SEL, },
>         { IMX93_CLK_CCM_CKO3,           "ccm_cko3_root",        0x1d80, CKO1_SEL, },
>         { IMX93_CLK_CCM_CKO4,           "ccm_cko4_root",        0x1e00, CKO2_SEL, },
> -       { IMX93_CLK_HSIO,               "hsio_root",            0x1e80, LOW_SPEED_IO_SEL, },
> +       { IMX93_CLK_HSIO,               "hsio_root",            0x1e80, LOW_SPEED_IO_SEL, CLK_IS_CRITICAL},

Similarly add a comment for critical flag please.