linux-kernel - Re: [PATCH v2] clk: mediatek: fix dependency of MT7986 ADC clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20221027233030.0F3FAC433D6@smtp.kernel.org>
Date:   Thu, 27 Oct 2022 16:30:27 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Daniel Golle <daniel@...rotopia.org>
Cc:     Matthias Brugger <matthias.bgg@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        Sam Shih <sam.shih@...iatek.com>,
        Miles Chen <miles.chen@...iatek.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Chen-Yu Tsai <wenst@...omium.org>
Subject: Re: [PATCH v2] clk: mediatek: fix dependency of MT7986 ADC clocks

Quoting Daniel Golle (2022-10-27 16:24:35)
> On Thu, Oct 27, 2022 at 02:41:49PM -0700, Stephen Boyd wrote:
> > Quoting Daniel Golle (2022-10-26 09:18:07)
> > > It seems like CLK_INFRA_ADC_FRC_CK always need to be enabled for
> > > CLK_INFRA_ADC_26M_CK to work. Instead of adding this dependency to the
> > > mtk-thermal and mt6577_auxadc drivers, add dependency to the clock
> > > driver clk-mt7986-infracfg.c.
> > 
> > Is this a cleanup patch? Or a pre-requisite for thermal and auxadc
> > drivers? I don't understand the priority of this patch. Should I apply
> > it to fix a regression?
> 
> I'd say 'no', as AUXADC and thermal has not yet been added to
> mt7986a.dtsi, also the corresponding clocks are currently still unused.
> So while this commit does fix a previous commit, it doesn't have a direct
> impact and will only matter once thermal and auxadc units are added to
> mt7986.dtsi.

Thanks! Please include these details next time.